Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1244 - Publish #1363

Merged
merged 1 commit into from Jan 12, 2020
Merged

Fix #1244 - Publish #1363

merged 1 commit into from Jan 12, 2020

Conversation

@is2ei
Copy link
Contributor

is2ei commented Jan 12, 2020

Fixed react-static-plugin-stylus to work correctly.

The package react-static-plugin-stylus on npmjs.com is missing its main file.

$ ls -l node_modules/react-static-plugin-stylus/
total 24
-rw-r--r--   1 horie  staff  1077 Jan 12 22:48 LICENSE
-rw-r--r--   1 horie  staff   629 Jan 12 22:48 README.md
drwxr-xr-x  10 horie  staff   320 Jan 12 23:33 node_modules
-rw-r--r--   1 horie  staff   840 Jan 12 22:48 package.json
drwxr-xr-x   3 horie  staff    96 Jan 12 23:33 src
$ grep main node_modules/react-static-plugin-stylus/package.json 
  "main": "index.js",

Description

  • Changed main file from index.js to node.api.js since node.api.js will be created when you run $ yarn build.
  • Changed README to describe about react-static-plugin-stylus. I'm not sure why but it notes about react-static-plugin-less 馃槄

Changes/Tasks

  • Changed code

Motivation and Context

When I installed react-static-plugin-stylus, it does not contain the main file index.js.
It looks the package is not published correctly. Also, node.api.js is created when I run $ yarn build so I think the main file should be node.api.js.

鈿狅笍 NOTE: The package react-static-plugin-stylus on npmjs.com is broken. So, the package has to be published again after this change is merged.

Screenshots (if appropriate):

Types of changes

  • Refactoring/add tests (refactoring or adding test which isn't a fix or add a feature)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have updated the documentation accordingly
  • I have updated the CHANGELOG with a summary of my changes
  • My changes have tests around them
react-static-plugin-stylus correctly
@SleeplessByte

This comment has been minimized.

Copy link
Contributor

SleeplessByte commented Jan 12, 2020

main is not used in the react-static eco-system, so the package isn't really broken.

However, changing it to node.api.js is preferable.

@SleeplessByte SleeplessByte merged commit 66309bd into react-static:master Jan 12, 2020
6 checks passed
6 checks passed
Header rules No header rules processed
Details
Pages changed All files already uploaded
Details
Mixed content No mixed content detected
Details
Redirect rules 5 redirect rules processed
Details
Travis CI - Pull Request Build Passed
Details
deploy/netlify Deploy preview ready!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can鈥檛 perform that action at this time.