Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark .sketch file as binary #1376

Merged
merged 1 commit into from Feb 7, 2020
Merged

Conversation

@nddery
Copy link
Contributor

nddery commented Feb 7, 2020

Description

Closes #1339.

Changes/Tasks

  • Marks .sketch files as binary in .gitattributes

Motivation and Context

Before this change, upon cloning react-static to my computer I would get the following, per #1373 (comment).

~/Sites/react-static master*
❯ git status
On branch master
Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
        modified:   media/media.sketch

no changes added to commit (use "git add" and/or "git commit -a")

~/Sites/react-static master*
❯ git diff
warning: CRLF will be replaced by LF in media/media.sketch.
The file will have its original line endings in your working directory
diff --git a/media/media.sketch b/media/media.sketch
index d26a064..6b2f857 100644
Binary files a/media/media.sketch and b/media/media.sketch differ

This change ensure the directory is clean.

Types of changes

  • Refactoring/add tests (refactoring or adding test which isn't a fix or add a feature)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have updated the documentation accordingly
  • I have updated the CHANGELOG with a summary of my changes

I don't think this deserve an entry in the change log but if you think so I'll be happy to add one, just let me know!

  • My changes have tests around them
Copy link
Contributor

SleeplessByte left a comment

Yeah nice. I'll merge this into the release branch as well.
..I'll add the change log entry.

@SleeplessByte SleeplessByte merged commit f32c880 into react-static:master Feb 7, 2020
6 checks passed
6 checks passed
Header rules No header rules processed
Details
Pages changed All files already uploaded
Details
Mixed content No mixed content detected
Details
Redirect rules 5 redirect rules processed
Details
Travis CI - Pull Request Build Passed
Details
deploy/netlify Deploy preview ready!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.