New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Future components / wishlist #626

Open
javivelasco opened this Issue Jul 10, 2016 · 44 comments

Comments

Projects
None yet
@javivelasco
Member

javivelasco commented Jul 10, 2016

I'd like to list in this issue components that are wanted but not implemented yet. I'd distinguish two kind of components: defined by the spec but not included/not defined by the spec, but useful and implemented by other frameworks.

From the spec

  • Grid components as specified here
  • FAB as discussed here
  • BottomNavigation as documented here
  • BottomSheet Implemented by Angular Material here
  • Stepper as specified here

Out of the spec

  • PaperScrollHeaderPanel implemented by Polymer here
  • Timelinedefined by @dlebedynskyi here
  • FAB Circular loading indicator as detailed here
  • DataPickerInput component used to parse text and control the DatePicker as discussed here

I want to use this thread to discuss if components out of the spec should be created in a separated repository (react to this post with 👍) or inside the same repository under a different folder (react with 👎 ). I'm more with the first approach. Also the list can be used to track the progress and to hold references to other issues and PRs where the components are developed.

Consider this kind of a roadmap of new components. Make your requests replying to this instead of opening new issues.

@vmsoftware

This comment has been minimized.

Show comment
Hide comment
@vmsoftware

vmsoftware Jul 10, 2016

Contributor

@javivelasco

Really a great idea. I think RT is the best MD library that I have seen never and congratulations for it. great work!.

However I think the actual implementation of MD need some changes that would be excellent before think about new components or external components, I mean responsive components, a 12-columns based grid system to organize the content and a theme switcher with 'light theme' and 'dark theme', proposed by MD specification.

I think those changes are more important at this moment and I'm going to suggest my personal opinion about how it should be:

For responsive components we only need to set the width of each component external wrapper to 100% and organize the internal content relative to this wrapper. You can say it's not usefull, but if you think about 12-columns based grid system really is the best option. Why?

let me try to explain it,

The 12-columns grid system, work as follow:

  1. Make a .row class with 100% of width.
  2. Take 100% and divide between 12 then each columns have 8,3333333333% of width.
  3. Make CSS classes for 1,2,3,4,5,6,7,8,9,10,11 and 12 columns like col1, col2, col3.... col12. (8,3333333333% * column number). for example
  4. Make mediaQuerys for .row and .colxx classes if necessary.
.col3 {
 width: 25%;
}

Then the components with the 100%, fill .colxx wrapper and organize the components easy.

It looks like a hard work but if we take advantage of existing libraries it's really easy.

I suggest flexboxgrid.com. because it's ready to use and there is a react implementacion of this that use CSS Modules: Flexboxgrid react. Then I think is easy to merge with RT structure.

flexboxgrid include CSS classes for horizontal and vertical alignment, offset columns, distribution and it's really easy to use... the final user should use as follow:

<row>
   <col> any RT component</col>
   <col>another RT component</col>
</row>
...

About theme switcher, I think that is very useful and will reduce the issues about theming because the people will have a real example about how to customize the components (generally instead individually).

let me know what do you think

Contributor

vmsoftware commented Jul 10, 2016

@javivelasco

Really a great idea. I think RT is the best MD library that I have seen never and congratulations for it. great work!.

However I think the actual implementation of MD need some changes that would be excellent before think about new components or external components, I mean responsive components, a 12-columns based grid system to organize the content and a theme switcher with 'light theme' and 'dark theme', proposed by MD specification.

I think those changes are more important at this moment and I'm going to suggest my personal opinion about how it should be:

For responsive components we only need to set the width of each component external wrapper to 100% and organize the internal content relative to this wrapper. You can say it's not usefull, but if you think about 12-columns based grid system really is the best option. Why?

let me try to explain it,

The 12-columns grid system, work as follow:

  1. Make a .row class with 100% of width.
  2. Take 100% and divide between 12 then each columns have 8,3333333333% of width.
  3. Make CSS classes for 1,2,3,4,5,6,7,8,9,10,11 and 12 columns like col1, col2, col3.... col12. (8,3333333333% * column number). for example
  4. Make mediaQuerys for .row and .colxx classes if necessary.
.col3 {
 width: 25%;
}

Then the components with the 100%, fill .colxx wrapper and organize the components easy.

It looks like a hard work but if we take advantage of existing libraries it's really easy.

I suggest flexboxgrid.com. because it's ready to use and there is a react implementacion of this that use CSS Modules: Flexboxgrid react. Then I think is easy to merge with RT structure.

flexboxgrid include CSS classes for horizontal and vertical alignment, offset columns, distribution and it's really easy to use... the final user should use as follow:

<row>
   <col> any RT component</col>
   <col>another RT component</col>
</row>
...

About theme switcher, I think that is very useful and will reduce the issues about theming because the people will have a real example about how to customize the components (generally instead individually).

let me know what do you think

@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost Jul 10, 2016

+1
out of the spec should be created in a separated repository, but in the same organisation.

ghost commented Jul 10, 2016

+1
out of the spec should be created in a separated repository, but in the same organisation.

@kossel

This comment has been minimized.

Show comment
Hide comment
@kossel

kossel Jul 11, 2016

I agree with it needs to be fully responsive and have a grid system. currently using external grid lib
Also menu component needs to enhance, I think it's missing label menu , cascading menu and menu item nesting

https://material.google.com/components/menus.html#

kossel commented Jul 11, 2016

I agree with it needs to be fully responsive and have a grid system. currently using external grid lib
Also menu component needs to enhance, I think it's missing label menu , cascading menu and menu item nesting

https://material.google.com/components/menus.html#

@wtgtybhertgeghgtwtg

This comment has been minimized.

Show comment
Hide comment
@wtgtybhertgeghgtwtg

wtgtybhertgeghgtwtg Jul 11, 2016

I don't know about grid systems, but I think grid lists should be added. Since they're part of the spec and all.
https://material.google.com/components/grid-lists.html

wtgtybhertgeghgtwtg commented Jul 11, 2016

I don't know about grid systems, but I think grid lists should be added. Since they're part of the spec and all.
https://material.google.com/components/grid-lists.html

@dlebedynskyi

This comment has been minimized.

Show comment
Hide comment
@dlebedynskyi

dlebedynskyi Jul 11, 2016

Contributor

@wtgtybhertgeghgtwtg Agree with you.
We have whole app without any grid system and have no problems. I do fill like it was not used in material design for a reason. Flex is really saving the day here.
Grid lists should probably be in main react-toolbox

Contributor

dlebedynskyi commented Jul 11, 2016

@wtgtybhertgeghgtwtg Agree with you.
We have whole app without any grid system and have no problems. I do fill like it was not used in material design for a reason. Flex is really saving the day here.
Grid lists should probably be in main react-toolbox

@vmsoftware

This comment has been minimized.

Show comment
Hide comment
@vmsoftware

vmsoftware Jul 11, 2016

Contributor

@wtgtybhertgeghgtwtg, @dlebedynskyi

Of course, you can make UI without grid sistema but 12-columns grid system is more EASY and FLEXIBLE than manual layout design and MD have included the spec for it.

Take a look: https://material.google.com/layout/responsive-ui.html

There are 2 important sections: BREAKPOINTS and GRID.

Contributor

vmsoftware commented Jul 11, 2016

@wtgtybhertgeghgtwtg, @dlebedynskyi

Of course, you can make UI without grid sistema but 12-columns grid system is more EASY and FLEXIBLE than manual layout design and MD have included the spec for it.

Take a look: https://material.google.com/layout/responsive-ui.html

There are 2 important sections: BREAKPOINTS and GRID.

@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost Jul 11, 2016

I agree with victor.

The md spec has a nice way of doing it.

I used it with polymer a year ago and it was very nice because it's baked
into polymer and just works.

On Mon, 11 Jul 2016, 19:35 Victor Molano, notifications@github.com wrote:

@wtgtybhertgeghgtwtg https://github.com/wtgtybhertgeghgtwtg,
@dlebedynskyi https://github.com/dlebedynskyi

Of course, you can make UI without grid sistema but 12-columns grid system
is more EASY and FLEXIBLE than manual layout design and MD have included
the spec for it.

Take a look: https://material.google.com/layout/responsive-ui.html

There are 2 important sections: BREAKPOINTS and GRID.


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#626 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AAJgKq9W2zzEOaIzPwCwYCMhoW2qQp7Xks5qUn7KgaJpZM4JI21K
.

ghost commented Jul 11, 2016

I agree with victor.

The md spec has a nice way of doing it.

I used it with polymer a year ago and it was very nice because it's baked
into polymer and just works.

On Mon, 11 Jul 2016, 19:35 Victor Molano, notifications@github.com wrote:

@wtgtybhertgeghgtwtg https://github.com/wtgtybhertgeghgtwtg,
@dlebedynskyi https://github.com/dlebedynskyi

Of course, you can make UI without grid sistema but 12-columns grid system
is more EASY and FLEXIBLE than manual layout design and MD have included
the spec for it.

Take a look: https://material.google.com/layout/responsive-ui.html

There are 2 important sections: BREAKPOINTS and GRID.


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#626 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AAJgKq9W2zzEOaIzPwCwYCMhoW2qQp7Xks5qUn7KgaJpZM4JI21K
.

@vmsoftware

This comment has been minimized.

Show comment
Hide comment
@vmsoftware

vmsoftware Jul 12, 2016

Contributor

@javivelasco what do you think?

Contributor

vmsoftware commented Jul 12, 2016

@javivelasco what do you think?

@thomasnaudin

This comment has been minimized.

Show comment
Hide comment
@thomasnaudin

thomasnaudin Jul 12, 2016

I agree for the grid-system. Currently we're using react-grid-layout, which integrates pretty well with React-Toolbox ; maybe something to take inspiration from ?

thomasnaudin commented Jul 12, 2016

I agree for the grid-system. Currently we're using react-grid-layout, which integrates pretty well with React-Toolbox ; maybe something to take inspiration from ?

@JeroenNelen

This comment has been minimized.

Show comment
Hide comment
@JeroenNelen

JeroenNelen Jul 13, 2016

concerning suggestions, can it be that there currently only is a iconMenu? No popover/menu with just text? So you can click text and it will open a menu?
If not, that would be very nice as well.

JeroenNelen commented Jul 13, 2016

concerning suggestions, can it be that there currently only is a iconMenu? No popover/menu with just text? So you can click text and it will open a menu?
If not, that would be very nice as well.

@abigtoe

This comment has been minimized.

Show comment
Hide comment
@abigtoe

abigtoe Jul 16, 2016

Adding a grid will make the effort to migrate bootstrap sites to RT much simpler.

abigtoe commented Jul 16, 2016

Adding a grid will make the effort to migrate bootstrap sites to RT much simpler.

@javivelasco

This comment has been minimized.

Show comment
Hide comment
@javivelasco

javivelasco Jul 16, 2016

Member

It looks like everybody is claiming a grid! I agree with you, it's useful, but there are some tools to make a custom grid with just a few lines. I'm using at work lost.io and it's really easy. You just define your CSS grid, postcss adds the styles and you can just require the CSS module and add the classes you've defined with divs or whatever you choose (because you shouldn't use always wrapper divs!).

I personally do not miss a grid usually but I think it could be cool to define one fitting MD spec. I'm adding it to the list and it should be top priority.

@vmsoftware Thank you so much! I agree with you, the light theme should come. I hoped somebody to work on it, it shouldn't be difficult just changing variables. I wouldn't make a switch as it is, usually you have one theme or another but it's easy stuff. Responsive components are really important as well, I'm going to track it with an issue to study components that fit just anywhere and components that actually need some changes.

@JeroenNelen Did you try to create a custom component opening a Menu? It should be pretty straightforward if you check the IconMenu component code.

Member

javivelasco commented Jul 16, 2016

It looks like everybody is claiming a grid! I agree with you, it's useful, but there are some tools to make a custom grid with just a few lines. I'm using at work lost.io and it's really easy. You just define your CSS grid, postcss adds the styles and you can just require the CSS module and add the classes you've defined with divs or whatever you choose (because you shouldn't use always wrapper divs!).

I personally do not miss a grid usually but I think it could be cool to define one fitting MD spec. I'm adding it to the list and it should be top priority.

@vmsoftware Thank you so much! I agree with you, the light theme should come. I hoped somebody to work on it, it shouldn't be difficult just changing variables. I wouldn't make a switch as it is, usually you have one theme or another but it's easy stuff. Responsive components are really important as well, I'm going to track it with an issue to study components that fit just anywhere and components that actually need some changes.

@JeroenNelen Did you try to create a custom component opening a Menu? It should be pretty straightforward if you check the IconMenu component code.

@vmsoftware

This comment has been minimized.

Show comment
Hide comment
@vmsoftware

vmsoftware Jul 20, 2016

Contributor

@javivelasco, about "somebody to work on it"... I'm absolutely ready to work with you. let me know how can I help you and I'll make it with pleasure.

Contributor

vmsoftware commented Jul 20, 2016

@javivelasco, about "somebody to work on it"... I'm absolutely ready to work with you. let me know how can I help you and I'll make it with pleasure.

@javivelasco

This comment has been minimized.

Show comment
Hide comment
@javivelasco

javivelasco Jul 20, 2016

Member

I'm happy to read it! I'm scheduling a little and right now I'm working on the PostCSS migration. I have some ideas for the website playground and the integration process that are going to give the final touch to make react-toolbox the easiest ui-kit to configure and customize.

My idea is to open issues to track components development from here and to use this thread as a way to keep up with people requests. As soon as we migrate to PostCSS we are opening issues for each component and tracking the progress from there. Anyway if you want to start already to draft an implementation or gathering ideas from already-implemented components it would be great :)

Member

javivelasco commented Jul 20, 2016

I'm happy to read it! I'm scheduling a little and right now I'm working on the PostCSS migration. I have some ideas for the website playground and the integration process that are going to give the final touch to make react-toolbox the easiest ui-kit to configure and customize.

My idea is to open issues to track components development from here and to use this thread as a way to keep up with people requests. As soon as we migrate to PostCSS we are opening issues for each component and tracking the progress from there. Anyway if you want to start already to draft an implementation or gathering ideas from already-implemented components it would be great :)

@skirunman

This comment has been minimized.

Show comment
Hide comment
@skirunman

skirunman Jul 22, 2016

I agree that getting full responsive support with a Material compliant grid should be #1 goal, mobile is just too important. I would also say that non-compliant Material spec components should not be in this library. Finally, there are a couple of key spec'ed components that are missing and key for mobile.

Bottom Navigation
Bottom Sheets

Also, where is support for Subheaders?

Great package and keep up the good work!

skirunman commented Jul 22, 2016

I agree that getting full responsive support with a Material compliant grid should be #1 goal, mobile is just too important. I would also say that non-compliant Material spec components should not be in this library. Finally, there are a couple of key spec'ed components that are missing and key for mobile.

Bottom Navigation
Bottom Sheets

Also, where is support for Subheaders?

Great package and keep up the good work!

@wtgtybhertgeghgtwtg

This comment has been minimized.

Show comment
Hide comment
@wtgtybhertgeghgtwtg

wtgtybhertgeghgtwtg Jul 22, 2016

New components should probably be second to #565, if only to avoid doing things twice.

wtgtybhertgeghgtwtg commented Jul 22, 2016

New components should probably be second to #565, if only to avoid doing things twice.

@javivelasco

This comment has been minimized.

Show comment
Hide comment
@javivelasco

javivelasco Jul 24, 2016

Member

@skirunman I think BottomSheets were already added but I moved it to the spec components list. Subheaders look like a very small component for me. Lists for example already supports them. Probably each component able to have them in context should has its own.

Member

javivelasco commented Jul 24, 2016

@skirunman I think BottomSheets were already added but I moved it to the spec components list. Subheaders look like a very small component for me. Lists for example already supports them. Probably each component able to have them in context should has its own.

@javivelasco

This comment has been minimized.

Show comment
Hide comment
@javivelasco

javivelasco Jul 24, 2016

Member

BTW, new components would have to wait for #666 as @wtgtybhertgeghgtwtg said!

Member

javivelasco commented Jul 24, 2016

BTW, new components would have to wait for #666 as @wtgtybhertgeghgtwtg said!

@ro-savage

This comment has been minimized.

Show comment
Hide comment
@ro-savage

ro-savage Aug 10, 2016

Contributor

I didn't actually read this before making the datepicker accept keyboard inputs. So hopefully #704 is suitable for DataPickerInput component used to parse text and control the DatePicker as discussed here

Contributor

ro-savage commented Aug 10, 2016

I didn't actually read this before making the datepicker accept keyboard inputs. So hopefully #704 is suitable for DataPickerInput component used to parse text and control the DatePicker as discussed here

@wtgtybhertgeghgtwtg

This comment has been minimized.

Show comment
Hide comment
@wtgtybhertgeghgtwtg

wtgtybhertgeghgtwtg Aug 24, 2016

What about navigational transitions? Although that might take some work on figuring out how to play nice with react-router.

wtgtybhertgeghgtwtg commented Aug 24, 2016

What about navigational transitions? Although that might take some work on figuring out how to play nice with react-router.

@acornejo

This comment has been minimized.

Show comment
Hide comment
@acornejo

acornejo Aug 24, 2016

Contributor

+1 for bottomnavigation and bottomsheets.

I would add, expand-collapsable lists (already available in material-ui), spec here:
https://material.google.com/components/lists-controls.html#lists-controls-types-of-list-controls

And fullscreen dialogs, spec here:
https://material.google.com/components/dialogs.html#dialogs-full-screen-dialogs

Also, having the hide-on-scroll behavior for the navbar would be great! (same for bottomnavigation, if/when its added).

Contributor

acornejo commented Aug 24, 2016

+1 for bottomnavigation and bottomsheets.

I would add, expand-collapsable lists (already available in material-ui), spec here:
https://material.google.com/components/lists-controls.html#lists-controls-types-of-list-controls

And fullscreen dialogs, spec here:
https://material.google.com/components/dialogs.html#dialogs-full-screen-dialogs

Also, having the hide-on-scroll behavior for the navbar would be great! (same for bottomnavigation, if/when its added).

@javivelasco

This comment has been minimized.

Show comment
Hide comment
@javivelasco

javivelasco Aug 24, 2016

Member

BottomSheets are easy to implement I think. They will come soon but first I need to finish #666 you are going to love it.

@wtgtybhertgeghgtwtg looks like quite difficult stuff but 😍 Now I want to implement a test with dialogs 😱

Member

javivelasco commented Aug 24, 2016

BottomSheets are easy to implement I think. They will come soon but first I need to finish #666 you are going to love it.

@wtgtybhertgeghgtwtg looks like quite difficult stuff but 😍 Now I want to implement a test with dialogs 😱

@neekey

This comment has been minimized.

Show comment
Hide comment
@neekey

neekey Sep 2, 2016

Can we have Popover ? For the moment may still need to use menu to work around it, and menu always tries to cover the trigger itself. Here are my user cases:

image

image

I implemented these using Material UI's popover, http://www.material-ui.com/#/components/popover

neekey commented Sep 2, 2016

Can we have Popover ? For the moment may still need to use menu to work around it, and menu always tries to cover the trigger itself. Here are my user cases:

image

image

I implemented these using Material UI's popover, http://www.material-ui.com/#/components/popover

@javivelasco

This comment has been minimized.

Show comment
Hide comment
@javivelasco

javivelasco Sep 2, 2016

Member

Yeah, some components currently implemented are going to be splitted, an example is the Menu which will be separated so you can use the ClippingBox as a popover to be used in just any other context. First we have to update the docs and release the PostCSS version so we don't dup work.

Member

javivelasco commented Sep 2, 2016

Yeah, some components currently implemented are going to be splitted, an example is the Menu which will be separated so you can use the ClippingBox as a popover to be used in just any other context. First we have to update the docs and release the PostCSS version so we don't dup work.

@threehams

This comment has been minimized.

Show comment
Hide comment
@threehams

threehams Oct 6, 2016

The FAB is a tough one, since it fits into general questions about material motion and transformation.
https://material.google.com/motion/transforming-material.html
https://material.google.com/motion/choreography.html

There isn't really anything about the FAB that makes it different from any other transforming or moving material - except possibly speed dial, which is a simple staggered translate. The examples given in the Material docs are just examples, and I think it makes sense to keep complex animations as composable as any other component.

Should this library try to come up with solutions for material transformation, or does that belong in a separate dependency? Some animations are extremely difficult to pull off while being fast enough for mobile - a thumbnail expanding into image is the hardest problem I've tried to tackle so far, given the bad performance of anything other than translate/rotate/scale.

threehams commented Oct 6, 2016

The FAB is a tough one, since it fits into general questions about material motion and transformation.
https://material.google.com/motion/transforming-material.html
https://material.google.com/motion/choreography.html

There isn't really anything about the FAB that makes it different from any other transforming or moving material - except possibly speed dial, which is a simple staggered translate. The examples given in the Material docs are just examples, and I think it makes sense to keep complex animations as composable as any other component.

Should this library try to come up with solutions for material transformation, or does that belong in a separate dependency? Some animations are extremely difficult to pull off while being fast enough for mobile - a thumbnail expanding into image is the hardest problem I've tried to tackle so far, given the bad performance of anything other than translate/rotate/scale.

@thomasthiebaud

This comment has been minimized.

Show comment
Hide comment
@thomasthiebaud

thomasthiebaud Nov 3, 2016

Is there some plan for a stepper ? Like defined here https://material.google.com/components/steppers.html

thomasthiebaud commented Nov 3, 2016

Is there some plan for a stepper ? Like defined here https://material.google.com/components/steppers.html

@RabidPuffin

This comment has been minimized.

Show comment
Hide comment
@RabidPuffin

RabidPuffin Dec 8, 2016

Bottom Nav is top of the list with a bullet.

RabidPuffin commented Dec 8, 2016

Bottom Nav is top of the list with a bullet.

@olegstepura

This comment has been minimized.

Show comment
Hide comment
@olegstepura

olegstepura Jan 23, 2017

Contributor

Hi! Since issue about responsiveness #804 is closed in favor of this one, here is how react toolbox official website is rendred on mobile:

0

Contributor

olegstepura commented Jan 23, 2017

Hi! Since issue about responsiveness #804 is closed in favor of this one, here is how react toolbox official website is rendred on mobile:

0

@javivelasco

This comment has been minimized.

Show comment
Hide comment
@javivelasco

javivelasco Jan 23, 2017

Member

Responsive is part of the plan :) It will come with 2.0

Member

javivelasco commented Jan 23, 2017

Responsive is part of the plan :) It will come with 2.0

@javivelasco javivelasco added the Future label Jan 23, 2017

@mvanlonden

This comment has been minimized.

Show comment
Hide comment
@mvanlonden

mvanlonden Jan 23, 2017

The grid system isn't too much of a need for me. I'd rather have the grid list tiles with all these spiffy variations.

mvanlonden commented Jan 23, 2017

The grid system isn't too much of a need for me. I'd rather have the grid list tiles with all these spiffy variations.

@stunaz

This comment has been minimized.

Show comment
Hide comment
@stunaz

stunaz Jan 29, 2017

+1 for Stepper component

stunaz commented Jan 29, 2017

+1 for Stepper component

@olegstepura

This comment has been minimized.

Show comment
Hide comment
@olegstepura

olegstepura Jan 30, 2017

Contributor

+1 for theme switcher, responsive grid, and a simple Paper component. Navigational transitions would also be very handy.

Contributor

olegstepura commented Jan 30, 2017

+1 for theme switcher, responsive grid, and a simple Paper component. Navigational transitions would also be very handy.

@javivelasco

This comment has been minimized.

Show comment
Hide comment
@javivelasco

javivelasco Jan 30, 2017

Member

I'm ok for Paper, maybe navigation transitions, but Grid can be imported from other small projects but I guess it's ok to have one with the MD spec widths and breakpoints. Theme switcher? It should be supported just by changing a prop in the ThemeProvider. The upcoming migration will allow it!

Member

javivelasco commented Jan 30, 2017

I'm ok for Paper, maybe navigation transitions, but Grid can be imported from other small projects but I guess it's ok to have one with the MD spec widths and breakpoints. Theme switcher? It should be supported just by changing a prop in the ThemeProvider. The upcoming migration will allow it!

@olegstepura

This comment has been minimized.

Show comment
Hide comment
@olegstepura

olegstepura Jan 31, 2017

Contributor

It's ok to have Grid outsourced. But I suggest adding some options in README and Layout examples (links to suggested grid components, examples). So that end user sees why it's not included (Separation of concerns) and how to use other libs together with react-toolbox.

Contributor

olegstepura commented Jan 31, 2017

It's ok to have Grid outsourced. But I suggest adding some options in README and Layout examples (links to suggested grid components, examples). So that end user sees why it's not included (Separation of concerns) and how to use other libs together with react-toolbox.

@izakfilmalter

This comment has been minimized.

Show comment
Hide comment
@izakfilmalter

izakfilmalter Jan 31, 2017

Contributor

I think grid is rather pointless to implement. If you look at Play Music which is in polymer or Firebase which is in Angular, there is no grid. The grid is part of the design process, that there is consistent spacing between elements. But it doesn't materialize in the dom thanks to flex-box and that most components are opinionated about their width.

I do need stepper for the current thing I am working on. I can take a stab at it in a week's time.

Contributor

izakfilmalter commented Jan 31, 2017

I think grid is rather pointless to implement. If you look at Play Music which is in polymer or Firebase which is in Angular, there is no grid. The grid is part of the design process, that there is consistent spacing between elements. But it doesn't materialize in the dom thanks to flex-box and that most components are opinionated about their width.

I do need stepper for the current thing I am working on. I can take a stab at it in a week's time.

@javivelasco

This comment has been minimized.

Show comment
Hide comment
@javivelasco

javivelasco Jan 31, 2017

Member

I think the same. As soon as we get the migration ready there will be need for tons of examples. The documentation has to be improved showing some use cases... I usually get questions where the solution is just to tweak with some CSS.

The future playground will import files from gists to mount examples, this way anybody will be able to contribute with examples. I need some time to get it properly working :(

Member

javivelasco commented Jan 31, 2017

I think the same. As soon as we get the migration ready there will be need for tons of examples. The documentation has to be improved showing some use cases... I usually get questions where the solution is just to tweak with some CSS.

The future playground will import files from gists to mount examples, this way anybody will be able to contribute with examples. I need some time to get it properly working :(

@devarsh

This comment has been minimized.

Show comment
Hide comment
@devarsh

devarsh Feb 4, 2017

@javivelasco any plans on including stepper component, it exists in the Material Design specs

devarsh commented Feb 4, 2017

@javivelasco any plans on including stepper component, it exists in the Material Design specs

@javivelasco

This comment has been minimized.

Show comment
Hide comment
@javivelasco

javivelasco Feb 7, 2017

Member

Yes @devarsh looks like a fun component to work on. Just added it to the list

Member

javivelasco commented Feb 7, 2017

Yes @devarsh looks like a fun component to work on. Just added it to the list

@drager

This comment has been minimized.

Show comment
Hide comment
@drager

drager Feb 20, 2017

Contributor

@izakfilmalter @devarsh @javivelasco: We have built a stepper component that we're using with react-toolbox. Currently not so much documentation but will add some soon. An example is present though.

Contributor

drager commented Feb 20, 2017

@izakfilmalter @devarsh @javivelasco: We have built a stepper component that we're using with react-toolbox. Currently not so much documentation but will add some soon. An example is present though.

@javivelasco

This comment has been minimized.

Show comment
Hide comment
@javivelasco

javivelasco Feb 20, 2017

Member

That's so cool @drager ! Feel free to send a PR to add a link in the readme as related projects/additions

Member

javivelasco commented Feb 20, 2017

That's so cool @drager ! Feel free to send a PR to add a link in the readme as related projects/additions

@drager

This comment has been minimized.

Show comment
Hide comment
@drager

drager Feb 22, 2017

Contributor

@javivelasco: We need to get some better documentation for it first I think. But after that we can fix that :)

Contributor

drager commented Feb 22, 2017

@javivelasco: We need to get some better documentation for it first I think. But after that we can fix that :)

@Pajn

This comment has been minimized.

Show comment
Hide comment
@Pajn

Pajn Mar 10, 2017

Contributor

Writing documentation took a bit more time than one might prefer but I finally pushed at least some initial examples and API docs.
In terms of material design and react-toolbox, what's currently there is basically the mobile steppers but we are interested in adding more. If anyone would like to contribute parts of the other steppers that would be great!

https://beanloop.github.io/react-step/

Contributor

Pajn commented Mar 10, 2017

Writing documentation took a bit more time than one might prefer but I finally pushed at least some initial examples and API docs.
In terms of material design and react-toolbox, what's currently there is basically the mobile steppers but we are interested in adding more. If anyone would like to contribute parts of the other steppers that would be great!

https://beanloop.github.io/react-step/

@vsai

This comment has been minimized.

Show comment
Hide comment
@vsai

vsai Jun 1, 2017

For components that are outside the spec, PaperScrollHeaderPanel, Timeline, Stepper, etc. what is the separate repository that these components will be placed in?
There seems to be quite a few different repos available, and was wondering if react-toolbox had a dedicated repo for this?

https://github.com/MaximKomlev/react-toolbox-additions
https://beanloop.github.io/react-step/ mentioned above by Pajn

There are also quite a few different Grid components and links mentioned above. Is there a conclusion as to what react-toolbox would be implementing?

vsai commented Jun 1, 2017

For components that are outside the spec, PaperScrollHeaderPanel, Timeline, Stepper, etc. what is the separate repository that these components will be placed in?
There seems to be quite a few different repos available, and was wondering if react-toolbox had a dedicated repo for this?

https://github.com/MaximKomlev/react-toolbox-additions
https://beanloop.github.io/react-step/ mentioned above by Pajn

There are also quite a few different Grid components and links mentioned above. Is there a conclusion as to what react-toolbox would be implementing?

@shasiuk1

This comment has been minimized.

Show comment
Hide comment
@shasiuk1

shasiuk1 Aug 1, 2018

Any chance to see Grid in nearest release or any plans to add it?
If not, what's the best alternative?
Thnx

shasiuk1 commented Aug 1, 2018

Any chance to see Grid in nearest release or any plans to add it?
If not, what's the best alternative?
Thnx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment