Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to sort a data table by clicking a table heading #1035

Closed
wants to merge 1 commit into from

Conversation

@tuckerconnelly
Copy link

tuckerconnelly commented Dec 7, 2016

Adds the ability to sort columns by clicking the table header. Accepts an onClick in the model, which will make the column clickable. Then, you can pass props.sortColumn and props.sortDirection into the <Table /> to get the up/down icon to display.

@tuckerconnelly tuckerconnelly force-pushed the KaleoSoftware:table-sorts branch from d077f13 to 959013d Dec 7, 2016
@javivelasco
Copy link
Member

javivelasco commented Jan 11, 2017

Thank you @tuckerconnelly I have been keeping this unmerges because the Table is already deprecated in favour of a more flexible version. We are keeping the 1.x in the master branch so if you think it's worthy feel free to open a PR there. Dev holds now the 2.0 beta with some rewritten components

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.