Conversation
Fix typeof check in isBrowser function
…t Object.entries().
Babel-polyfill activation to specs
|
I'm looking to give this a go because I share the need expressed in #963. How do I get started on this branch? I've tried @mmazzarolo 's bolierplate but that gives me on |
… so that bundle sizes will be smaller for not including the whole ramda package.
Minimize bundle size because of ramda
|
Here is the build system. I forgot to mention here! |
|
Okay, I trying to use this beta but right now I'm getting problems like: ERROR in ./app/components/students/StudentForm/ResponsibleFormSection.js ERROR in ./app/components/students/StudentConfirmDialog/index.js ... and so on... Before trying the beta, the components was getting compiled right. This is my webpack config dev: |
|
@aislanmaia Your configuration needs to support CSS modules with postcss for react-toolbox. I see this line here: loader: ExtractTextPlugin.extract('style', 'css?sourceMap&modules&importLoaders=1&localIdentName=[name]__[local]___[hash:base64:5]!postcss!sass'),I guess that's the loader that was being used for react-toolbox. You just have to remove postcss: function () {
return [autoprefixer];
}I recommend to use just css-next. Check out the configuration examples in the root of the repository and the /docs folder. Also, you may use that loader config just for react-toolbox because right now there are two different loaders with the same regex! |
|
Any timeline on the official 2.0 release? Downloaded the npm install and it is still in beta. I see the comment on fixing up the documentation and playground, but that comment was in Jul 2016. Personally, I would be good with some documentation and have the playground come later. I've had to dig through the code to find out how to use certain components. 2.0 looks like it may fulfill our needs, but would not be allowed to use a beta. |
This PR brings a complete migration of react-toolbox to post-css along with changes that are side effects of this migration. The theming philosophy behind this migration is basically the same as before. Each component has a configuration file where some variables are defined and used at time of generating styles. Those variables can be overridden to customize appearance. We are using:
Layoutcomponent since some properties need to be repeated for different screen sizes.calc, etc.Layoutcomponent to generate a bunch of classes that define sizes of the drawer element, for example.With this implementation we don't need to make tricks to prepend variables SASS files to react-toolbox stylesheets. We just need a variables Javascript file defining theming variables we want to override and pass it to the custom properties plugin configuration. In case you are using sass variables from react-toolbox now, with the new version you'd need to change to postcss. Apart from that, if basically works the same way.
Of course this is a huge change because it implies a technology change and I think it should be released under
2.0.0. The amazing news is that we can do awesome stuff with this change that I'd like to include in this PR before merging:Please leave your feedback in this PR!