Make CSS processing the same in dev and prod#13011
Conversation
Co-authored-by: Vatsal Joshi <vatz88@gmail.com>
|
Hi @c-w! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
This pull request is a revival of #8148 given that react-scripts is now on webpack 5 and MiniCssExtractPlugin now supports hot reloading.
With this pull request, we can make CSS processing the same between dev and prod builds which helps in avoiding hard to debug issues where some CSS works fine locally but doesn't work when deployed due to ordering conflicts or similar. It's a problem I ran into recently and currently have to work-around by manually patching react-scripts in postinstall.
Tagging @andriijas @elektronik2k5 @vatz88 who participated in the original pull request.