Skip to content

remove hermes note - #35555

Closed
dcangulo wants to merge 1 commit into
react:mainfrom
dcangulo:chore/remove-note
Closed

remove hermes note#35555
dcangulo wants to merge 1 commit into
react:mainfrom
dcangulo:chore/remove-note

Conversation

@dcangulo

@dcangulo dcangulo commented Dec 5, 2022

Copy link
Copy Markdown
Contributor

Summary

This note was added when upgrading from 0.69x to 0.70.x when hermes_enabled is explicitly set to true.

Screenshot 2022-12-05 at 11 26 15

But on 0.71, we are now using get_default_flags again which makes the note obsolete.

Changelog

[Internal] [Removed] - removed hermes note

Test Plan

N/A

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 5, 2022
@analysis-bot

Copy link
Copy Markdown
Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,104,305 +283
android hermes armeabi-v7a 6,473,067 +219
android hermes x86 7,522,581 +448
android hermes x86_64 7,381,008 +601
android jsc arm64-v8a 8,971,778 +0
android jsc armeabi-v7a 7,703,208 +0
android jsc x86 9,034,387 +0
android jsc x86_64 9,511,779 +0

Base commit: ea9e78d
Branch: main

@analysis-bot

Copy link
Copy Markdown
Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: ea9e78d
Branch: main

@pull-bot

pull-bot commented Dec 5, 2022

Copy link
Copy Markdown

PR build artifact for a7cff29 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

@pull-bot

pull-bot commented Dec 5, 2022

Copy link
Copy Markdown

PR build artifact for a7cff29 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

@facebook-github-bot

Copy link
Copy Markdown
Contributor

@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@github-actions

github-actions Bot commented Dec 5, 2022

Copy link
Copy Markdown

This pull request was successfully merged by @dcangulo in 032bed4.

When will my fix make it into a release? | Upcoming Releases

@github-actions github-actions Bot added the Merged This PR has been merged. label Dec 5, 2022
@dcangulo
dcangulo deleted the chore/remove-note branch December 5, 2022 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Type: Removal

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants