Set InspectorFlags in RCTAppDelegate#41976
Closed
huntie wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D51589221 |
Base commit: 1045b22 |
huntie
force-pushed
the
export-D51589221
branch
from
4ab8581 to
fbc11e3
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D51589221 |
huntie
force-pushed
the
export-D51589221
branch
from
fbc11e3 to
f284eef
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D51589221 |
huntie
force-pushed
the
export-D51589221
branch
from
f284eef to
9e786e3
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D51589221 |
huntie
force-pushed
the
export-D51589221
branch
from
9e786e3 to
57ff3ef
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D51589221 |
huntie
force-pushed
the
export-D51589221
branch
from
57ff3ef to
1fb2eb7
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D51589221 |
huntie
force-pushed
the
export-D51589221
branch
from
1fb2eb7 to
bd29d7f
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D51589221 |
huntie
force-pushed
the
export-D51589221
branch
from
bd29d7f to
c4d8e76
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D51589221 |
Summary:
Progress towards an opt-in setup for our new CDP backend.
- Wires up D51563107 to conditionally disable the legacy Hermes debugger via `ReactNativeConfig`.
- **Configuration covered**: iOS, for the `RCTAppDelegate` code path.
- Create C++-only overload of `RCTAppSetupPrepareApp`, deprecate the previous function.
Changelog:
[iOS][Deprecated] - Deprecate `RCTAppSetupPrepareApp`, replaced with C++ overload
Reviewed By: motiz88
Differential Revision: D51589221
huntie
force-pushed
the
export-D51589221
branch
from
c4d8e76 to
dd60aab
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D51589221 |
huntie
force-pushed
the
export-D51589221
branch
from
dd60aab to
0f5b401
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D51589221 |
Contributor
|
This pull request has been merged in 7a4950b. |
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Jan 29, 2024
Summary: Removes call to `InspectorFlags::initFromConfig`, since this approach is being replaced with `ReactNativeFeatureFlags`. This change is separated out as it originally made a public API deprecation. Changelog: [iOS][Deprecated] - **Un-deprecates** `RCTAppSetupPrepareApp` (reverts react#41976) Differential Revision: D53048207 fbshipit-source-id: 31549c4ff9c11a5bd0e6d2887ca4063a3cf63c85
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Feb 6, 2024
…42642) Summary: Removes call to `InspectorFlags::initFromConfig`, since this approach is being replaced with `ReactNativeFeatureFlags`. This change is separated out as it originally made a public API deprecation. Changelog: [iOS][Deprecated] - **Un-deprecates** `RCTAppSetupPrepareApp` (reverts react#41976) Reviewed By: motiz88 Differential Revision: D53048207
facebook-github-bot
pushed a commit
that referenced
this pull request
Feb 13, 2024
Summary: Pull Request resolved: #42642 Removes call to `InspectorFlags::initFromConfig`, since this approach is being replaced with `ReactNativeFeatureFlags`. This change is separated out as it originally made a public API deprecation. Changelog: [iOS][Deprecated] - **Un-deprecates** `RCTAppSetupPrepareApp` (reverts #41976) Reviewed By: motiz88 Differential Revision: D53048207 fbshipit-source-id: 8624020f1e9e19f9f1ee75af9b177e922e36c5d9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Progress towards an opt-in setup for our new CDP backend.
ReactNativeConfig.RCTAppDelegatecode path.RCTAppSetupPrepareApp, deprecate the previous function.Changelog:
[iOS][Deprecated] - Deprecate
RCTAppSetupPrepareApp, replaced with C++ overloadReviewed By: motiz88
Differential Revision: D51589221