Revert experiment that disables NativeModule codegen#41978
Closed
mdvacca wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D52223650 |
Base commit: 3690e44 |
mdvacca
force-pushed
the
export-D52223650
branch
from
d68ec5e to
88c02fe
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D52223650 |
mdvacca
force-pushed
the
export-D52223650
branch
from
88c02fe to
f1d4a9d
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D52223650 |
mdvacca
force-pushed
the
export-D52223650
branch
from
f1d4a9d to
dfc7912
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D52223650 |
mdvacca
force-pushed
the
export-D52223650
branch
from
dfc7912 to
f50f447
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D52223650 |
mdvacca
force-pushed
the
export-D52223650
branch
from
f50f447 to
39f55de
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D52223650 |
mdvacca
force-pushed
the
export-D52223650
branch
from
39f55de to
8d8e537
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D52223650 |
mdvacca
force-pushed
the
export-D52223650
branch
from
8d8e537 to
7484cde
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D52223650 |
mdvacca
force-pushed
the
export-D52223650
branch
from
7484cde to
bddb929
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D52223650 |
mdvacca
force-pushed
the
export-D52223650
branch
from
bddb929 to
0d91e08
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D52223650 |
mdvacca
force-pushed
the
export-D52223650
branch
from
0d91e08 to
742a49c
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D52223650 |
mdvacca
force-pushed
the
export-D52223650
branch
from
742a49c to
e3f75cc
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D52223650 |
Summary: I'm revering the removal of ReactModule codegen. We are postpoinging the removal of the codegen for the future, the reasons are: - resources: the experiment that removes the codegen shows neutral metrics, but the codegen is shared between bridge and bridgeless, so we will need to implement and test the removal for bridge and we don't have the time to do this right now. - reduce fragmentation: we don't want to fragment NativeModules configuration between bridge and bridgeless, doing so will bring a lot of confusion to developers - we don't want to introduce a public APIs in 0.73 that we know they are not used in production for now, we better remove these "unstable" apis before 0.74 cut Note: I'm updating ReactAndroid.api because this is an intended change of APIs which were not part of 0.73 and we don't want them to be part of 0.74. changelog: [internal] internal Reviewed By: RSNara Differential Revision: D52223650
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Jan 12, 2024
…#41978) Summary: I'm revering the removal of ReactModule codegen. We are postpoinging the removal of the codegen for the future, the reasons are: - resources: the experiment that removes the codegen shows neutral metrics, but the codegen is shared between bridge and bridgeless, so we will need to implement and test the removal for bridge and we don't have the time to do this right now. - reduce fragmentation: we don't want to fragment NativeModules configuration between bridge and bridgeless, doing so will bring a lot of confusion to developers - we don't want to introduce a public APIs in 0.73 that we know they are not used in production for now, we better remove these "unstable" apis before 0.74 cut Note: I'm updating ReactAndroid.api because this is an intended change of APIs which were not part of 0.73 and we don't want them to be part of 0.74. changelog: [internal] internal Reviewed By: RSNara Differential Revision: D52223650
mdvacca
force-pushed
the
export-D52223650
branch
from
e3f75cc to
6cb1ac6
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D52223650 |
Contributor
|
This pull request has been merged in 0b14eed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
I'm revering the removal of ReactModule codegen.
We are postpoinging the removal of the codegen for the future, the reasons are:
Note: I'm updating ReactAndroid.api because this is an intended change of APIs which were not part of 0.73 and we don't want them to be part of 0.74.
changelog: [internal] internal
Differential Revision: D52223650