Migrate flag enablePropIteratorSetter to new system by rubennorte · Pull Request #42432 · react/react-native

rubennorte · 2024-01-20T19:07:11Z

Summary:
Changelog: [internal]

This feature flag is accessed through CoreFeatures but it's initialized a few different ways:

Android: assigned via ReactFeatureFlags, which is overridden by apps.
iOS: ReactNativeConfig that's mapped to a dynamic configuration.

This migrates the flag to the new feature flag system.

Differential Revision: D52810065

facebook-github-bot · 2024-01-20T19:07:44Z

This pull request was exported from Phabricator. Differential Revision: D52810065

facebook-github-bot · 2024-01-20T19:19:55Z

This pull request was exported from Phabricator. Differential Revision: D52810065

facebook-github-bot · 2024-01-20T19:30:34Z

This pull request was exported from Phabricator. Differential Revision: D52810065

facebook-github-bot · 2024-01-20T19:41:53Z

This pull request was exported from Phabricator. Differential Revision: D52810065

facebook-github-bot · 2024-01-20T20:03:38Z

This pull request was exported from Phabricator. Differential Revision: D52810065

facebook-github-bot · 2024-01-20T20:11:08Z

This pull request was exported from Phabricator. Differential Revision: D52810065

facebook-github-bot · 2024-01-20T20:31:26Z

This pull request was exported from Phabricator. Differential Revision: D52810065

facebook-github-bot · 2024-01-20T20:44:22Z

This pull request was exported from Phabricator. Differential Revision: D52810065

facebook-github-bot · 2024-01-20T21:19:30Z

This pull request was exported from Phabricator. Differential Revision: D52810065

facebook-github-bot · 2024-01-21T01:41:58Z

This pull request was exported from Phabricator. Differential Revision: D52810065

facebook-github-bot · 2024-01-21T13:24:21Z

This pull request was exported from Phabricator. Differential Revision: D52810065

facebook-github-bot · 2024-01-21T13:56:20Z

This pull request was exported from Phabricator. Differential Revision: D52810065

facebook-github-bot · 2024-01-21T14:04:16Z

This pull request was exported from Phabricator. Differential Revision: D52810065

facebook-github-bot · 2024-01-30T10:43:54Z

This pull request was exported from Phabricator. Differential Revision: D52810065

facebook-github-bot · 2024-02-05T14:05:17Z

This pull request was exported from Phabricator. Differential Revision: D52810065

Differential Revision: D53406924 fbshipit-source-id: 604270275eccab3965bd4fed32c9356a172b80db

Differential Revision: D53416934 fbshipit-source-id: 6284f767ca984c02ef92f60e89f610cb9d3c0b26

Differential Revision: D53351484 fbshipit-source-id: 771ec265d975fae1aacdb360fbebc01a7ce3921f

Differential Revision: D53351483 fbshipit-source-id: b72a4802c8c8bb62c72d0ad76567c4e5e196d52b

Differential Revision: D53352391 fbshipit-source-id: 3e0c482ee990721f223999476844aa4c6e05a31e

Differential Revision: D53360609 fbshipit-source-id: 45cf69c48dcc10ce19a0c16eb5f18e7676afee11

Summary: Pull Request resolved: react#42432 Changelog: [internal] This feature flag is accessed through `CoreFeatures` but it's initialized a few different ways: * Android: assigned via `ReactFeatureFlags`, which is overridden by apps. * iOS: `ReactNativeConfig` that's mapped to a dynamic configuration. This migrates the flag to the new feature flag system. Reviewed By: mdvacca, RSNara Differential Revision: D52810065 fbshipit-source-id: 944d5a3d077b09788d9d6daad45dd2622f780ff0

facebook-github-bot · 2024-02-05T14:41:23Z

This pull request was exported from Phabricator. Differential Revision: D52810065

facebook-github-bot · 2024-02-13T20:42:05Z

This pull request has been merged in ced4994.

facebook-github-bot · 2024-02-14T03:12:06Z

This pull request has been reverted by 6c2f088.

facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Jan 20, 2024

facebook-github-bot added the fb-exported label Jan 20, 2024

rubennorte force-pushed the export-D52810065 branch from ebb3428 to 7fbc814 Compare January 20, 2024 19:20

rubennorte force-pushed the export-D52810065 branch from 7fbc814 to b2cf164 Compare January 20, 2024 19:30

rubennorte force-pushed the export-D52810065 branch from b2cf164 to 8f63cfa Compare January 20, 2024 19:42

rubennorte force-pushed the export-D52810065 branch from 8f63cfa to 89e73e3 Compare January 20, 2024 20:03

rubennorte force-pushed the export-D52810065 branch from 89e73e3 to 539a6cd Compare January 20, 2024 20:11

rubennorte force-pushed the export-D52810065 branch from 539a6cd to f10ca67 Compare January 20, 2024 20:31

rubennorte force-pushed the export-D52810065 branch from f10ca67 to 9bec2e3 Compare January 20, 2024 20:44

rubennorte force-pushed the export-D52810065 branch from 9bec2e3 to 1378eef Compare January 20, 2024 21:19

rubennorte force-pushed the export-D52810065 branch from 7428a4c to b4bad9c Compare January 21, 2024 13:24

rubennorte force-pushed the export-D52810065 branch from b4bad9c to 66d0d5b Compare January 21, 2024 13:56

rubennorte force-pushed the export-D52810065 branch from 66d0d5b to cc09f1e Compare January 21, 2024 14:04

rubennorte force-pushed the export-D52810065 branch from cc09f1e to 90c1897 Compare January 30, 2024 10:44

rubennorte force-pushed the export-D52810065 branch from 90c1897 to fabd03c Compare February 5, 2024 14:05

rubennorte and others added 7 commits February 5, 2024 06:35

Improve thread safety of ReactNativeFeatureFlags

206b327

Differential Revision: D53406924 fbshipit-source-id: 604270275eccab3965bd4fed32c9356a172b80db

Minor improvements in ReactNativeFeatureFlagsAccessor

8f82d37

Differential Revision: D53416934 fbshipit-source-id: 6284f767ca984c02ef92f60e89f610cb9d3c0b26

Use Flow in feature flags scripts

298eb81

Differential Revision: D53351484 fbshipit-source-id: 771ec265d975fae1aacdb360fbebc01a7ce3921f

Move feature flag definitions to JS file instead of JSON

9f3c3d8

Differential Revision: D53351483 fbshipit-source-id: b72a4802c8c8bb62c72d0ad76567c4e5e196d52b

Reduce number of generated files for the feature flags system

2c68fc7

Differential Revision: D53352391 fbshipit-source-id: 3e0c482ee990721f223999476844aa4c6e05a31e

Add runtime check to ensure feature flags are only overridden once

5b38df1

Differential Revision: D53360609 fbshipit-source-id: 45cf69c48dcc10ce19a0c16eb5f18e7676afee11

rubennorte force-pushed the export-D52810065 branch from fabd03c to 118fe40 Compare February 5, 2024 14:41

facebook-github-bot closed this in ced4994 Feb 13, 2024

facebook-github-bot added the Merged This PR has been merged. label Feb 13, 2024

facebook-github-bot added the Reverted label Feb 14, 2024

Conversation

rubennorte commented Jan 20, 2024

Uh oh!

facebook-github-bot commented Jan 20, 2024

Uh oh!

facebook-github-bot commented Jan 20, 2024

Uh oh!

facebook-github-bot commented Jan 20, 2024

Uh oh!

facebook-github-bot commented Jan 20, 2024

Uh oh!

facebook-github-bot commented Jan 20, 2024

Uh oh!

facebook-github-bot commented Jan 20, 2024

Uh oh!

facebook-github-bot commented Jan 20, 2024

Uh oh!

facebook-github-bot commented Jan 20, 2024

Uh oh!

facebook-github-bot commented Jan 20, 2024

Uh oh!

facebook-github-bot commented Jan 21, 2024

Uh oh!

facebook-github-bot commented Jan 21, 2024

Uh oh!

facebook-github-bot commented Jan 21, 2024

Uh oh!

facebook-github-bot commented Jan 21, 2024

Uh oh!

facebook-github-bot commented Jan 30, 2024

Uh oh!

facebook-github-bot commented Feb 5, 2024

Uh oh!

facebook-github-bot commented Feb 5, 2024

Uh oh!

facebook-github-bot commented Feb 13, 2024

Uh oh!

facebook-github-bot commented Feb 14, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants