Skip to content

'[skip ci] [RN][Android] Fix nullability in DefaultTurboModuleManagerDelegate#42850

Closed
mdvacca wants to merge 1 commit into
react:mainfrom
mdvacca:export-D53393139
Closed

'[skip ci] [RN][Android] Fix nullability in DefaultTurboModuleManagerDelegate#42850
mdvacca wants to merge 1 commit into
react:mainfrom
mdvacca:export-D53393139

Conversation

@mdvacca

@mdvacca mdvacca commented Feb 4, 2024

Copy link
Copy Markdown
Contributor

Summary:
HybridData can not be null, fixing nullability in DefaultTurboModuleManagerDelegate

changelog: [internal] internal

Differential Revision: D53393139

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Feb 4, 2024
@facebook-github-bot

facebook-github-bot commented Feb 4, 2024

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D53393139

@facebook-github-bot

facebook-github-bot commented Feb 4, 2024

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D53393139

1 similar comment
@facebook-github-bot

facebook-github-bot commented Feb 4, 2024

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D53393139

@facebook-github-bot

facebook-github-bot commented Feb 4, 2024

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D53393139

1 similar comment
@facebook-github-bot

facebook-github-bot commented Feb 4, 2024

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D53393139

@mdvacca mdvacca force-pushed the export-D53393139 branch 2 times, most recently from 205fb6f to 338c698 Compare February 5, 2024 02:51
@facebook-github-bot

facebook-github-bot commented Feb 5, 2024

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D53393139

5 similar comments
@facebook-github-bot

facebook-github-bot commented Feb 5, 2024

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D53393139

@facebook-github-bot

facebook-github-bot commented Feb 5, 2024

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D53393139

@facebook-github-bot

facebook-github-bot commented Feb 5, 2024

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D53393139

@facebook-github-bot

facebook-github-bot commented Feb 5, 2024

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D53393139

@facebook-github-bot

facebook-github-bot commented Feb 5, 2024

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D53393139

@facebook-github-bot

facebook-github-bot commented Feb 6, 2024

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D53393139

@mdvacca @facebook-github-bot
Fix nullability in DefaultTurboModuleManagerDelegate (react#42850)
d11d548 
Summary:

HybridData can not be null, fixing nullability in DefaultTurboModuleManagerDelegate

changelog: [internal] internal

Reviewed By: cortinico

Differential Revision: D53393139
mdvacca added a commit to mdvacca/react-native that referenced this pull request Feb 6, 2024
@mdvacca @facebook-github-bot
[skip ci] Fix nullability in DefaultTurboModuleManagerDelegate (react…
755c187 
…#42850)

Summary:

HybridData can not be null, fixing nullability in DefaultTurboModuleManagerDelegate

changelog: [internal] internal

Reviewed By: cortinico

Differential Revision: D53393139
@facebook-github-bot

facebook-github-bot commented Feb 6, 2024

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D53393139

mdvacca added a commit to mdvacca/react-native that referenced this pull request Feb 6, 2024
@mdvacca @facebook-github-bot
[skip ci] Fix nullability in DefaultTurboModuleManagerDelegate (react…
bbbe97e 
…#42850)

Summary:

HybridData can not be null, fixing nullability in DefaultTurboModuleManagerDelegate

changelog: [internal] internal

Reviewed By: cortinico

Differential Revision: D53393139
@analysis-bot

analysis-bot commented Feb 6, 2024

Copy link
Copy Markdown
Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 17,233,411 -10
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 20,600,223 +2
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: e4342f5
Branch: main

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Feb 6, 2024
@facebook-github-bot

facebook-github-bot commented Feb 6, 2024

Copy link
Copy Markdown
Contributor

This pull request has been merged in 3d1eb7e.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mdvacca @facebook-github-bot @analysis-bot