Do not eagerly allocate all view managers in DefaultReactNativeHost#42869
Closed
javache wants to merge 1 commit into
Closed
Do not eagerly allocate all view managers in DefaultReactNativeHost#42869javache wants to merge 1 commit into
javache wants to merge 1 commit into
Conversation
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D53406841 |
Base commit: d66d651 |
…acebook#42869) Summary: `DefaultReactNativeHost` builds a `ViewManagerRegistry` based on a list of ViewManagers, which is inefficient, as we have to allocate them all ahead of time (defeating the purpose of `ViewManagerOnDemandReactPackage`). Instead provide a `ViewManagerResolver`which lazily resolves them. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D53406841
javache
force-pushed
the
export-D53406841
branch
from
c38b946 to
a5cced3
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D53406841 |
Contributor
|
This pull request has been merged in f3977af. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
DefaultReactNativeHostbuilds aViewManagerRegistrybased on a list of ViewManagers, which is inefficient, as we have to allocate them all ahead of time (defeating the purpose ofViewManagerOnDemandReactPackage). Instead provide aViewManagerResolverwhich lazily resolves them.Changelog: [Internal]
Differential Revision: D53406841