Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,9 @@

public interface Binding {

public void startSurface(
int surfaceId, @NonNull String moduleName, @NonNull NativeMap initialProps);
void startSurface(int surfaceId, @NonNull String moduleName, @NonNull NativeMap initialProps);

public void startSurfaceWithConstraints(
void startSurfaceWithConstraints(
int surfaceId,
String moduleName,
NativeMap initialProps,
Expand All @@ -33,11 +32,11 @@ public void startSurfaceWithConstraints(
boolean isRTL,
boolean doLeftAndRightSwapInRTL);

public void stopSurface(int surfaceId);
void stopSurface(int surfaceId);

public void setPixelDensity(float pointScaleFactor);
void setPixelDensity(float pointScaleFactor);

public void setConstraints(
void setConstraints(
int surfaceId,
float minWidth,
float maxWidth,
Expand All @@ -48,23 +47,23 @@ public void setConstraints(
boolean isRTL,
boolean doLeftAndRightSwapInRTL);

public void driveCxxAnimations();
void driveCxxAnimations();

public void reportMount(int surfaceId);
void reportMount(int surfaceId);

public ReadableNativeMap getInspectorDataForInstance(EventEmitterWrapper eventEmitterWrapper);
ReadableNativeMap getInspectorDataForInstance(EventEmitterWrapper eventEmitterWrapper);

public void register(
void register(
@NonNull RuntimeExecutor runtimeExecutor,
@NonNull RuntimeScheduler runtimeScheduler,
@NonNull FabricUIManager fabricUIManager,
@NonNull EventBeatManager eventBeatManager,
@NonNull ComponentFactory componentFactory,
@NonNull ReactNativeConfig reactNativeConfig);

public void unregister();
void unregister();

public void registerSurface(SurfaceHandlerBinding surfaceHandler);
void registerSurface(SurfaceHandlerBinding surfaceHandler);

public void unregisterSurface(SurfaceHandlerBinding surfaceHandler);
void unregisterSurface(SurfaceHandlerBinding surfaceHandler);
}
Original file line number Diff line number Diff line change
Expand Up @@ -675,12 +675,11 @@ public int getSurfaceId() {
return View.NO_ID;
}

@NonNull
@Override
public String toString() {
String propsString =
IS_DEVELOPMENT_ENVIRONMENT
? (props != null ? props.toHashMap().toString() : "<null>")
: "<hidden>";
IS_DEVELOPMENT_ENVIRONMENT ? props.toHashMap().toString() : "<hidden>";
return String.format("SYNC UPDATE PROPS [%d]: %s", reactTag, propsString);
}
};
Expand Down Expand Up @@ -972,7 +971,7 @@ private void addViewCommandMountItem(final DispatchCommandMountItem mountItem) {
}

private void postChoreographerCallbackIfNecessary() {
if (ReactFeatureFlags.enableOnDemandReactChoreographer == false) {
if (!ReactFeatureFlags.enableOnDemandReactChoreographer) {
return;
}

Expand Down Expand Up @@ -1159,6 +1158,7 @@ public int getSurfaceId() {
return View.NO_ID;
}

@NonNull
@Override
public String toString() {
return "CLEAR_JS_RESPONDER";
Expand Down Expand Up @@ -1245,7 +1245,7 @@ public void run() {
}

// Collect surface IDs for all the mount items
List<Integer> surfaceIds = new ArrayList();
List<Integer> surfaceIds = new ArrayList<>();
for (MountItem mountItem : mountItems) {
if (mountItem != null && !surfaceIds.contains(mountItem.getSurfaceId())) {
surfaceIds.add(mountItem.getSurfaceId());
Expand Down