build backwards compat API for runtime pointer#43013
Closed
philIip wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D53645247 |
philIip
force-pushed
the
export-D53645247
branch
from
8836513 to
aed0e92
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D53645247 |
philIip
force-pushed
the
export-D53645247
branch
from
aed0e92 to
0ecdc97
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D53645247 |
philIip
force-pushed
the
export-D53645247
branch
from
0ecdc97 to
6a2181d
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D53645247 |
Base commit: 1c4ed12 |
philIip
force-pushed
the
export-D53645247
branch
from
6a2181d to
028e7bb
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D53645247 |
Summary: Changelog: [Android][Added] This is a pre-deprecated API to give access to the jsi::Runtime in Android in bridgeless. In bridge, this value is exposed via the ReactContext, but is not implemented in the BridgelessReactContext. We do that here. This should work out of the box in bridgeless if you are already retrieveing the pointer via ReactContext. However, we recommend users to eventually migrate towards C++ TurboModule or the RuntimeExecutor if possible. This will be removed in the future. Reviewed By: RSNara Differential Revision: D53645247
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D53645247 |
philIip
force-pushed
the
export-D53645247
branch
from
028e7bb to
94faff8
Compare
Contributor
|
This pull request has been merged in 315be82. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Android][Added]
This is a pre-deprecated API to give access to the jsi::Runtime in Android in bridgeless. In bridge, this value is exposed via the ReactContext, but is not implemented in the BridgelessReactContext. We do that here.
This should work out of the box in bridgeless if you are already retrieveing the pointer via ReactContext. However, we recommend users to eventually migrate towards C++ TurboModule or the RuntimeExecutor if possible. This will be removed in the future.
Reviewed By: RSNara
Differential Revision: D53645247