Implement Runtime.addBinding (global bindings only)#43065
Closed
motiz88 wants to merge 3 commits into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D53266709 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D53266709 |
motiz88
force-pushed
the
export-D53266709
branch
from
90fb5d0 to
62f2e1f
Compare
Base commit: 80ec096 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D53266709 |
motiz88
force-pushed
the
export-D53266709
branch
from
62f2e1f to
9bba487
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D53266709 |
motiz88
force-pushed
the
export-D53266709
branch
from
9bba487 to
592a4d3
Compare
Differential Revision: D53759776
Differential Revision: D53776531
Summary: Pull Request resolved: react#43065 Changelog: [Internal] Implements support for [`Runtime.addBinding`](https://cdpstatus.reactnative.dev/devtools-protocol/tot/Runtime#method-addBinding) in the new RN CDP backend. This implementation is mostly complete and matches Chrome's behaviour, but does not include the ability to target bindings by execution context (the optional `executionContextId` and `executionContextName` params) - that will come in a separate diff for ease of review/landing. Incidentally, this diff also introduces the `JsiIntegrationPortableTest::expectMessageFromPage` helper, which allows us to "asynchronously" extract the contents of an expected message. For consistency and clarity, we refactor all the other `EXPECT_CALL(this->fromPage(), onMessage(JsonEq(...)))` assertions to use it as well. Reviewed By: huntie Differential Revision: D53266709
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D53266709 |
motiz88
force-pushed
the
export-D53266709
branch
from
592a4d3 to
9b8e8aa
Compare
Contributor
|
This pull request has been merged in da03d7b. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
Implements support for
Runtime.addBindingin the new RN CDP backend.This implementation is mostly complete and matches Chrome's behaviour, but does not include the ability to target bindings by execution context (the optional
executionContextIdandexecutionContextNameparams) - that will come in a separate diff for ease of review/landing.Incidentally, this diff also introduces the
JsiIntegrationPortableTest::expectMessageFromPagehelper, which allows us to "asynchronously" extract the contents of an expected message. For consistency and clarity, we refactor all the otherEXPECT_CALL(this->fromPage(), onMessage(JsonEq(...)))assertions to use it as well.Reviewed By: huntie
Differential Revision: D53266709