feat(react-dom): Add enterKeyHint#18634
Merged
Merged
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 8c75389:
|
4 tasks
necolas
approved these changes
Apr 22, 2020
Collaborator
Author
|
deleted by accident |
|
This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated. |
Collaborator
Author
|
bump |
Collaborator
|
Looks like we forgot to merge. Thanks! |
This was referenced Mar 6, 2021
This was referenced Mar 15, 2021
Merged
1 task
This was referenced Oct 1, 2024
mrizwanashiq
pushed a commit
to mrizwanashiq/react
that referenced
this pull request
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test Plan
Ran /fixtures/attribute-behavior locally. Results available under https://drive.google.com/open?id=1j5PJgc-NcKXsGZh8GqBfHXHfdEwd9ii_.
Note: Should I update the fixture for
inputModeas well? It is still reading from the attribute but the property is supported as of chrome 66.https://github.com/facebook/react/blob/8c75389319d479dc5b2f2cf4b2c7084549913084/fixtures/attribute-behavior/src/attributes.js#L955
Codesandbox using this PR: https://codesandbox.io/s/enterkeyhint-6l5t3