-
-
Notifications
You must be signed in to change notification settings - Fork 206
refactor: Rename components and group them on Storybook #332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit e151203:
|
|
Sheesh, that's a big PR. I think we should first rename the components and then later on rework their APIs if needed. But first let's take care of component names.
Additional renames we need that I've found in the guideline:
|
|
@arturbien thanks for the thorough review. Following your notes, I moved Storybook and property changes to individual PRs, and adjusted all component names. Additionally:
|
This also renames the menu variant to thin.
BREAKING CHANGE: LoadingIndicator was removed from the library.
…ield to NumberInput
This also moves TabBody and Tab inside Tabs
This also adds the field variant and refactors createBorderStyles to implement all border styles.
This also moves the Table* subcomponents into the Table folder.
This also moves Windows* subcomponents to the Windows folder.
|
🎉 This PR is included in version 4.0.0-beta.12 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 4.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |

Following up on #285, I'd like to propose the following changes:
/docsto StorybookThe following components were renamed:
BartoHandleCutouttoScrollViewDesktoptoMonitorDividertoSeparatorFieldsettoGroupBoxListtoMenuListListItemtoMenuListItemLoadingIndicatorwas deletedPaneltoFrameProgresstoProgressBarTextFieldtoTextInputTreetoTreeViewThe following components were moved (not altering any exports):
Tab,TabBodyalongsideTabsTableBody,TableDataCell,TableHead,TableHeadCell,TableRowalongsideTableWindowContent,WindowHeaderalongsideWindowAdditionally, this was changed:
createBorderStyleswas refactored with all possible border styles, aligned with Windows 95 terminologySwitchBase: moved tocommonfolderComponent.displayNameto improve React debugging.mdxfiles, given they were almost identical to the already existing storiesAll changes are backward compatible by exporting the previous names with files on
src/legacy, and marked as@deprecated, with the exception ofLoadingIndicator.Closes #285.