-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix 369 compareAtPrice #383
Conversation
ProductDetailInfo has been split into 3 separate components - ProductDetailPrice - ProductDetailDescription - ProductDetailVendor
Moved back into WIP. This is missing the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested against the branch inside reactioncommerce/reaction#4722
Looks good to go once that PR is merged.
@mikemurray @kieckhafer what do we need to do to get this merged? |
@spencern just checked it again after the |
Resolves #369
Impact: minor
Type: bugfix
Issue
compareAtPrice
doesn't display on the PDP page when availableSolution
compareAtPrice
displayBreaking changes
ProductDetailInfo has been split into 3 separate components
Testing
Run with the branch from this PR (reactioncommerce/reaction#4731 ) or release-2.0.0-rc.5 or later if it's been merged
compareAtPrice
for a variant and/or variant optioncompareAtPrice
is displayed. (It's the crossed-out price)compareAtPrice
is above the price