Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 369 compareAtPrice #383

Merged
merged 26 commits into from
Oct 19, 2018
Merged

Fix 369 compareAtPrice #383

merged 26 commits into from
Oct 19, 2018

Conversation

mikemurray
Copy link
Member

@mikemurray mikemurray commented Oct 10, 2018

Resolves #369
Impact: minor
Type: bugfix

Issue

compareAtPrice doesn't display on the PDP page when available

Solution

  • Split the ProductDetailInfo info component
  • In the new ProductDetailPrice component, add the compareAtPrice display
  • Add a compact layout to the ProductDetailPrice that's used for mobile

Breaking changes

ProductDetailInfo has been split into 3 separate components

  • ProductDetailPrice
  • ProductDetailDescription
  • ProductDetailVendor

Testing

Run with the branch from this PR (reactioncommerce/reaction#4731 ) or release-2.0.0-rc.5 or later if it's been merged

  1. In Reaction, set the compareAtPrice for a variant and/or variant option
  2. On the PDP page for that product, verify the compareAtPrice is displayed. (It's the crossed-out price)
  3. On mobile, verify the compareAtPrice is above the price

@mikemurray mikemurray changed the title [WIP] Fix 369 compareAtPrice Fix 369 compareAtPrice Oct 12, 2018
@mikemurray mikemurray changed the title Fix 369 compareAtPrice [WIP] Fix 369 compareAtPrice Oct 12, 2018
@mikemurray
Copy link
Member Author

Moved back into WIP. This is missing the compareAtPrice display for the variant option.

@mikemurray mikemurray changed the title [WIP] Fix 369 compareAtPrice Fix 369 compareAtPrice Oct 12, 2018
Copy link
Member

@kieckhafer kieckhafer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested against the branch inside reactioncommerce/reaction#4722

Looks good to go once that PR is merged.

@spencern
Copy link
Contributor

@mikemurray @kieckhafer what do we need to do to get this merged?

@kieckhafer
Copy link
Member

kieckhafer commented Oct 18, 2018

@spencern just checked it again after the reaction code was merged in. This is good to go, merging now after tests pass.

@kieckhafer kieckhafer merged commit 558d94b into develop Oct 19, 2018
@kieckhafer kieckhafer deleted the fix-369-mikemurray-compare-at branch October 19, 2018 18:15
This was referenced Jan 15, 2019
@spencern spencern mentioned this pull request Jan 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The "Compare at" price is not displayed
3 participants