#443: PDP: Remove Tags display #447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #442
Impact: minor
Type: feature
Issue
Tags need to be removed from PDP to prepare for incoming changes to Tag logic. A Tag will be updated so that a Tag can be marked as inactive, for example, and not all Tags will have enabled live links. Because of this, we want to remove Tags from being displayed on PDP by default.
Solution
TagGriddisplay component from PDPTagGridcomponent entirelyBreaking changes
None
Screenshots
Given a product with tags in Admin:
No tags should show up:
Testing