Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
feat: AddressForm Component #128
Create an AddressForm component using reacto forms and preexisting form components
In the future, we'd like to have a more feature rich PhoneNumberInput that includes masking and real phone number validation.
Built with commit 77032f4
@rymorgan Yes the "no special character" formatter runs after each new input and on blur, I'd like to be able to pass the phone number format style to the
@cassytaylor I'll update that second address field label. I can make the phone field optional in the addressForm but I thought it was required now I might be making this up tho. As for having an "optional" convey down into the component I think that's a smart idea and I think the Field component would actually take care of it, it already has an
@nnnnat I think we can default it to US and from a little research (XXX) XXX-XXXX is the dominant format. The caveat here is that the component should allow the user to easily override that formatting for UK/Europe etc. But, if I understand your component, it seems like that is the case so
@nnnnat @cassytaylor - I think your idea of having a "'(Optional)' at the end of each field label if isRequired=false" is a good one for this specific component but probably doesn't work when you think about the operator side of things. Can that be something specific to this component? Or specific to storefront components?