Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some countries (like Qatar) do not use postal codes, but Reaction Commerce forbids to place an order without a postal code #3530

Closed
dmitry-fedyuk opened this Issue Jan 20, 2018 · 1 comment

Comments

4 participants
@dmitry-fedyuk
Copy link
Contributor

dmitry-fedyuk commented Jan 20, 2018

Expected behavior

Reaction Commerce should not require a postal code for countries not using postal codes:

Actual behavior

Reaction Commerce requires postal codes for all countries.

Steps to reproduce the behavior

01

Versions

Node: 9.4.0
NPM: 5.6.0
Meteor Node: 8.9.3
Meteor NPM: 5.5.1
Reaction CLI: 0.24.2
Reaction: 1.6.4
Reaction branch: master

@zenweasel

This comment has been minimized.

Copy link
Member

zenweasel commented Jan 21, 2018

That list would appear to be inaccurate as South Africa clearly has zip codes.
https://en.wikipedia.org/wiki/List_of_postal_codes_in_South_Africa

But the point still stands, that some of these countries don't and we shouldn't require it.

@aaronjudd aaronjudd added this to the Bugfix Sprint 1 milestone Feb 12, 2018

@Akarshit Akarshit self-assigned this Feb 13, 2018

spencern added a commit that referenced this issue Feb 13, 2018

@Akarshit Akarshit closed this Feb 14, 2018

This was referenced Feb 15, 2018

@spencern spencern referenced this issue Mar 9, 2018

Merged

Release 1.9.0 #3941

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.