Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sub navigation does not open on mobile #3679

Closed
nnnnat opened this issue Feb 8, 2018 · 0 comments

Comments

Projects
None yet
3 participants
@nnnnat
Copy link
Member

commented Feb 8, 2018

Expected behavior

  • Sub navigation should open when top-level nav item arrow is clicked

Actual behavior

  • Clicking the top-level nav item arrow send the user to the top-level tag page

Steps to reproduce the behavior

  • As an Admin created a new tag navigation item
  • Create subtags under the new top-level tag
  • In a mobile browser open the main reaction navigation and try to click the top-level item arrow

mobile-sub-nav

Versions

Node: 9.4.0
NPM: 5.6.0
Meteor Node: 8.9.3
Meteor NPM: 5.5.1
Reaction CLI: 0.26.4
Reaction: 1.8.0
Reaction branch: release-1.8.0

Poking around in the inspector It doesn't look like the sub nav has any mobile styles and is just hidden so this might need some design input on how these sub navs should look and work

@spencern spencern added this to the Bugfix Sprint 1 milestone Feb 9, 2018

@rymorgan rymorgan added UIX and removed design labels Feb 12, 2018

@nnnnat nnnnat self-assigned this Feb 14, 2018

@spencern spencern modified the milestones: Bugfix Sprint 1, Release 1.9 Feb 20, 2018

@spencern spencern closed this Feb 21, 2018

@spencern spencern referenced this issue Feb 22, 2018

Merged

Release 1.8.0 #3645

@spencern spencern referenced this issue Mar 9, 2018

Merged

Release 1.9.0 #3941

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.