Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to save a custom tax rate #4396

Closed
jamesporl opened this issue Jul 3, 2018 · 0 comments · Fixed by #4338
Closed

Unable to save a custom tax rate #4396

jamesporl opened this issue Jul 3, 2018 · 0 comments · Fixed by #4338
Assignees
@jamesporl

Comments

@jamesporl
Copy link
Contributor

Issue Description

Unable to save a custom tax rate

Steps to Reproduce

  1. As admin, click the Tax icon in the dashboard.
  2. Enable Custom Rates.
  3. Click "+" to add a custom rate and fill out the form. Then Save.
  4. The error alert will say "Taxes shopId is required."

Possible Solution

Not sure

Versions

Node: 8.11.2
NPM: 5.6.0
Meteor Node: 8.11.3
Meteor NPM: 5.10.0
Reaction CLI: 0.29.0
Reaction: 1.13.1
Reaction branch: master
@jamesporl jamesporl self-assigned this Jul 6, 2018
@jamesporl jamesporl mentioned this issue Jul 6, 2018
Merged
spencern added a commit that referenced this issue Jul 12, 2018
@spencern
Merge pull request #4405 from reactioncommerce/fix-4396-ajporlante-ca…
fa1d1d9 
…nt-save-custom-tax-rate

(fix) #4396 Unable to save custom tax rate
@spencern spencern mentioned this issue Jul 19, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jamesporl jamesporl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Release 1.14.0 reactioncommerce/reaction
1 participant
@jamesporl