Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Console error when typing a tag name on PDP - 1.17 Port Fix #4776

Closed
jeffcorpuz opened this issue Oct 24, 2018 · 0 comments

Comments

2 participants
@jeffcorpuz
Copy link
Contributor

commented Oct 24, 2018

Solved/Resolved:
#4438

Issue Description

On a fresh install, when typing a name as an admin adding tags on the PDP, I get the following browser console error:
Uncaught (in promise) TypeError: Cannot read property 'getShopId' of undefined at getShopLang (helpers.js:113) at lazyLoadSlugify (utils.js:9) at Object.getSlug (utils.js:41) at updateSuggestions (tagListContainer.js:17) at Object.TagListContainer.handleGetSuggestions.suggestionUpdateRequest [as onGetSuggestions] (tagListContainer.js:120) at TagItem.handleSuggestionsUpdateRequested.suggestion (tagItem.js:65) at onChange (modules.js?hash=23f5d5ff26091b4c36fe26678a7f0411864618d9:204880) at HTMLUnknownElement.callCallback (modules.js?hash=23f5d5ff26091b4c36fe26678a7f0411864618d9:174748) at Object.invokeGuardedCallbackDev (modules.js?hash=23f5d5ff26091b4c36fe26678a7f0411864618d9:174786) at Object.invokeGuardedCallback (modules.js?hash=23f5d5ff26091b4c36fe26678a7f0411864618d9:174835)

Steps to Reproduce

  1. Clone and startup
  2. Edit a product and start typing in the new tag auto-complete field
  3. Confirm browser console error

Possible Solution

Port Fix : #4673

Versions

Reaction: 1.17 (#4761)

@jeffcorpuz jeffcorpuz added this to the Pikes Peak milestone Oct 24, 2018

spencern added a commit that referenced this issue Nov 1, 2018

fix: console error when typing a tag name on PDP
Ports 1.x safe portions of #4673
Resolves #4776 console error appearing when typing a tag name on the PDP
4776 came with several other unrelated commits which remove unused code
I've left those changes intact and only removed code which would cause 1.x to break

spencern added a commit that referenced this issue Nov 2, 2018

Merge pull request #4790 from reactioncommerce/fix-4776-port-tag-name…
…-error-pdp

fix: console error tag name error pdp .. Resolves #4776

@jeffcorpuz jeffcorpuz closed this Nov 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.