Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Surcharge updating is delayed #4984

Open
aldeed opened this issue Feb 13, 2019 · 0 comments

Comments

2 participants
@aldeed
Copy link
Member

commented Feb 13, 2019

I noticed an issue with #4829 but didn't want to hold up merging it. When surcharges apply to only certain methods and you are switching between methods on the checkout page, the surcharge total is updated one time behind. In other words, you see what the surcharge total is for one method after you switch to a different method.

We had a similar issue before with taxes, and this may need a similar fix. If updateFulfillmentOptionsForGroup and/or selectFulfillmentOptionForGroup are changed to do a Cart.findOne after the appEvents.emit("afterCartUpdate", this should result in correct data being returned.

This is not necessarily a good long term fix for async data issues, though. We could also consider implementing the cart graphql subscription as a more future-proof fix.

@aldeed aldeed added this to the 🏔 Torreys milestone Feb 13, 2019

@aldeed aldeed added the bug label Feb 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.