Don't break out orders with quantities #2119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zenweasel
changed the title
aaronjudd
reviewed
Apr 14, 2017
| }); | ||
| return _.extend(item, { taxDetail }); | ||
| }); | ||
| } else { | ||
| items = returnItems; | ||
| } | ||
|
|
||
| /** |
There was a problem hiding this comment.
We need more comments, not less.
aaronjudd
reviewed
Apr 14, 2017
| for (const orderItem of orderItems) { | ||
| const cartItem = { | ||
| _id: orderItem.cartItemId, | ||
| _id: orderItem.cartItemId || orderItem._id, |
There was a problem hiding this comment.
Is this change / behaviour documented elsewhere? Should be added to release docs?
aaronjudd
approved these changes
Apr 14, 2017
This was referenced Apr 17, 2017
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2102 and resolves blocker with Avalara
Changes the behavior
copyCartToOrderto not break out lines with quantities into individual linesTo Test
This change should have no visibility to the user except for seeing new orders not broken out. The most important thing to test is that nothing is broken. With the exception for adding in some conditionals for Inventory hooks I didn't see any compatibility issues with moving forward from old versions.