Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for the addition of OAuth Providers #3231

Merged
merged 3 commits into from Nov 9, 2017

Conversation

4 participants
@pmn4
Copy link
Collaborator

pmn4 commented Nov 3, 2017

Goal: use an OAuth Provider other than Facebook/Google/Twitter/Instagram
Problem: the set of providers used to create the settings dashboard is inaccessible
Proposed Solution: offer a way to add to the list without exposing it outright

To test, I created a tiny plugin which adds Untappd (Foursquare for beer) and looks something like this:

meteor add brewline:accounts-untappd

plugins/custom/untappd-oauth/client/index.js:

import { ServiceConfigHelper } from "../../../core/accounts/client/helpers/util";
// (unrelated) is there a better path to use here? going up the directory tree feels unfortunate

ServiceConfigHelper.addProvider("Untappd", [
  { property: "clientId", label: "Client ID" },
  { property: "secret", label: "Client Secret" }
]);
@pmn4

This comment has been minimized.

Copy link
Collaborator Author

pmn4 commented Nov 3, 2017

(bitHound shows one failing file, but when you go to the site, the list of failing files is empty... :thinking_face:)

@spencern
Copy link
Member

spencern left a comment

Looks straightforward enough, but needs jsdocs.

@@ -102,4 +102,12 @@ export class ServiceConfigHelper {
return service;
});
}

This comment has been minimized.

Copy link
@spencern

spencern Nov 8, 2017

Member

need jsdocs here

pmn4 and others added some commits Nov 8, 2017

@zenweasel

This comment has been minimized.

Copy link
Member

zenweasel commented Nov 8, 2017

Running eslint on this locally shows no errors so I don't know what's up with Bithound. 👎

@spencern spencern changed the base branch from master to release-1.5.7 Nov 9, 2017

@spencern spencern referenced this pull request Nov 9, 2017

Merged

Release 1.5.7 #3259

@spencern spencern merged commit 954e2bf into reactioncommerce:release-1.5.7 Nov 9, 2017

1 of 3 checks passed

bitHound - Code
Details
bitHound - Dependencies
Details
security/snyk No new issues
Details
@machikoyasuda

This comment has been minimized.

Copy link
Member

machikoyasuda commented Nov 9, 2017

Woot @pmn4 🎊

Akarshit pushed a commit that referenced this pull request Jan 7, 2018

Merge pull request #3231 from pmn4/master
Allow for the addition of OAuth Providers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.