Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #3431. Correct style applied for guest users. #3423

Merged
merged 2 commits into from Jan 8, 2018

Conversation

4 participants
@Akarshit
Copy link
Contributor

Akarshit commented Dec 19, 2017

Fix for #3421

What was wrong

I didn't apply the CSS for image height when the user was not the admin user.

To test ->

The point is basically to load a big image that would take some time and test. These instruction are for testing in local

  1. Run reaction.
  2. Copy the URL of a image(from somewhere on the internet).
  3. Add return <image URL>; here (just return the URL from the function)
  4. Add BrowserPolicy.content.allowOriginForAll("*"); after this
  5. Go to the PDP of example-product. The image should load and show.

@Akarshit Akarshit requested a review from zenweasel Dec 19, 2017

@zenweasel

This comment has been minimized.

Copy link
Member

zenweasel commented Dec 19, 2017

@Akarshit This first link for where to make the return <image URL> change is broken.

@Akarshit

This comment has been minimized.

Copy link
Contributor Author

Akarshit commented Dec 20, 2017

@zenweasel Sorry. Updated now.

@@ -164,6 +164,21 @@

}

.gallery-image.no-fade-on-hover {

This comment has been minimized.

Copy link
@pmn4

pmn4 Jan 2, 2018

Collaborator

any sense in making this a mixin to use here and above (.admin-gallery-image.no-fade-on-hover)?

@zenweasel
Copy link
Member

zenweasel left a comment

I didn't test this with the method in the instructions but using the method I used to find this error and it appears to be working now

@spencern spencern changed the base branch from master to release-1.6.4 Jan 8, 2018

@spencern spencern merged commit ea25d38 into release-1.6.4 Jan 8, 2018

4 checks passed

Codacy/PR Quality Review Good work! A positive pull request.
Details
WIP ready for review
Details
ci/circleci Your tests passed on CircleCI!
Details
security/snyk No new issues
Details

@spencern spencern deleted the enhan-zoomImage branch Jan 8, 2018

@spencern spencern referenced this pull request Jan 8, 2018

Merged

Release 1.6.4 #3454

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.