Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix): "tag" should not be translated to "balise" in French #3448

Merged
merged 2 commits into from Jan 20, 2018

Conversation

3 participants
@loanlaux
Copy link

loanlaux commented Jan 5, 2018

In French, "tag" is not translated when referring to a meta keyword. See french article for "tag" on Wikipedia here.
Although one might use "mot-clé" (translated to "keyword") in particular occasions, "tag" is commonly used to describe a tag in the context of a blog article or (in this case) a product on an online store.

"Balise", the translation that is currently in place, is — for example — used when referring to HTML tags.

I thus advise that we use the word "tag" as a replacement for "balise".

Loan Laux

@zenweasel zenweasel self-requested a review Jan 8, 2018

@zenweasel
Copy link
Member

zenweasel left a comment

Thanks for the PR @loanlaux

@spencern spencern changed the base branch from master to release-1.6.5 Jan 20, 2018

@spencern spencern merged commit 3bbce74 into reactioncommerce:release-1.6.5 Jan 20, 2018

4 checks passed

Codacy/PR Quality Review Good work! A positive pull request.
Details
WIP ready for review
Details
ci/circleci Your tests passed on CircleCI!
Details
security/snyk No new issues
Details

@spencern spencern referenced this pull request Jan 20, 2018

Merged

Release 1.6.5 #3525

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.