Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 3473 fix typo and logic #3493

Merged
merged 1 commit into from Jan 20, 2018

Conversation

4 participants
@Akarshit
Copy link
Contributor

commented Jan 16, 2018

Fix for #3473

To test

  1. Run reaction
  2. Enable Avalara's address validation.
  3. Add the Example product to the cart and go to checkout step.
  4. For the checkout address enter the address as shown below in the screenshotscreen shot 2018-01-16 at 3 29 07 pm
  5. On Save change the address will be validated and saved.
@pmn4

This comment has been minimized.

Copy link
Collaborator

commented Jan 17, 2018

lgtm

@Akarshit Akarshit requested a review from zenweasel Jan 18, 2018

@zenweasel
Copy link
Member

left a comment

Tested. Verified fixed. This validation probably should be revisited/retested but this fixes this error.

@spencern spencern changed the base branch from master to release-1.6.5 Jan 20, 2018

@spencern spencern merged commit fe1ecac into release-1.6.5 Jan 20, 2018

4 checks passed

Codacy/PR Quality Review Good work! A positive pull request.
Details
WIP ready for review
Details
ci/circleci Your tests passed on CircleCI!
Details
security/snyk No new issues
Details

@spencern spencern deleted the fix-3473-akarshit-tax-address branch Jan 20, 2018

@spencern spencern referenced this pull request Jan 20, 2018

Merged

Release 1.6.5 #3525

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.