Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Email logs and email job queuing should check permissions #3553

Merged

Conversation

Projects
None yet
4 participants
@prinzdezibel
Copy link
Contributor

commented Jan 23, 2018

Closes #3542

  • Prevent Jobs publication to send data to client if user has not email
    permission
  • Prevent emails from being queued for resending if user has no email permission.
Email logs and email job queuing should not work if permission
"reaction-email" is not granted.

Closes #3542

Prevent Jobs publication to send data to client if user has not email
permission
Prevent emails from being queued for resending if user has no email permission.

@prinzdezibel prinzdezibel requested a review from impactmass Jan 23, 2018

@pmn4

This comment has been minimized.

Copy link
Collaborator

commented Jan 23, 2018

lgtm

@impactmass

This comment has been minimized.

Copy link
Member

commented Jan 23, 2018

Posted a comment on the main issue #3542 to answer before we review this

@spencern

This comment has been minimized.

Copy link
Member

commented Jan 23, 2018

Set the issue to blocked by #3542 per @impactmass comment

@impactmass impactmass added the blocked label Jan 23, 2018

@prinzdezibel

This comment has been minimized.

Copy link
Contributor Author

commented Jan 24, 2018

@impactmass @spencern : There's no dependency between this PR and #3524. It shouldn't be labeled as blocked.

@prinzdezibel

This comment has been minimized.

Copy link
Contributor Author

commented Jan 24, 2018

@spencern Seems like the ticket number's are transposed: It should be blocked because of #3542, not #3524.

@impactmass impactmass removed the blocked label Jan 24, 2018

@spencern spencern changed the base branch from master to release-1.7.0 Jan 26, 2018

@spencern spencern merged commit 2a1b6fc into release-1.7.0 Jan 26, 2018

4 checks passed

Codacy/PR Quality Review Good work! A positive pull request.
Details
WIP ready for review
Details
ci/circleci Your tests passed on CircleCI!
Details
security/snyk No new issues
Details

@spencern spencern deleted the fix-3542-prinzdezibel-fix-email-settings-permissions branch Jan 26, 2018

@spencern spencern referenced this pull request Jan 27, 2018

Merged

Release 1.7.0 #3605

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.