Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct value when you flag an order failed #3563

Merged
merged 1 commit into from Jan 24, 2018

Conversation

Projects
None yet
2 participants
@zenweasel
Copy link
Member

commented Jan 24, 2018

Resolves #3562

The wrong values was used to mark an order as failed export

To test

  1. Login as admin and enable Shopify export
  2. Cause the export to fail somehow (disabling network while using example-payment)
  3. Place an order
  4. Observe no error from marking the order failed (besides the failed export of course)

@zenweasel zenweasel requested a review from spencern Jan 24, 2018

@spencern
Copy link
Member

left a comment

Good catch. 👍

@spencern spencern changed the base branch from master to release-1.6.6 Jan 24, 2018

@spencern spencern merged commit b303e6f into release-1.6.6 Jan 24, 2018

4 checks passed

Codacy/PR Quality Review Good work! A positive pull request.
Details
WIP ready for review
Details
ci/circleci Your tests passed on CircleCI!
Details
security/snyk No new issues
Details

@spencern spencern deleted the fix-3562-brent-fix-shopify-mark-failed branch Jan 24, 2018

@spencern spencern referenced this pull request Jan 24, 2018

Merged

Release 1.6.6 #3565

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.