Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style: 3568 enable eslint rules for import, parens, and chained calls #3586

Merged
merged 7 commits into from Jan 26, 2018

Conversation

Projects
None yet
2 participants
@spencern
Copy link
Member

commented Jan 25, 2018

Resolves #3568 - part 3 of 3

Enables the following lint rules

 "import/export": "error",
    "import/order": ["error", {
      "groups": [
        "builtin",
        "external",
        "internal",
        "parent",
        "sibling",
        "index"
      ]
    }],
    "import/newline-after-import": "error",
    "import/no-duplicates": "error",
    "import/no-mutable-exports": "error",
    "import/no-named-default": "error",
    "new-parens": "error",
    "newline-per-chained-call": ["error", { "ignoreChainWithDepth": 4 }],

Resolves all issues that appeared when these lint rules were enabled.

@spencern spencern requested a review from willopez Jan 25, 2018

@spencern spencern changed the title Style: 3568 enable eslint rules Style: 3568 enable eslint rules for import, parens, and chained calls Jan 25, 2018

@spencern spencern added this to the Performance Sprint 1 milestone Jan 25, 2018

@willopez
Copy link
Member

left a comment

Looks great!

@@ -1,7 +1,6 @@
import url from "url";
import packageJson from "/package.json";
import { merge, uniqWith } from "lodash";
import _ from "lodash";
import _, { merge, uniqWith } from "lodash";

This comment has been minimized.

Copy link
@willopez

willopez Jan 26, 2018

Member

I believe importing _ will include all functions from underscore. Not clear an why we need both, importing all functions and then two named functions?

A new PR will be created to audit how lodash functions are imported across the project.

@spencern spencern changed the base branch from master to release-1.7.0 Jan 26, 2018

spencern added some commits Jan 26, 2018

Merge remote-tracking branch 'origin/release-1.7.0' into style-3568-p…
…art3-spencern-eslint-update-3

# Conflicts:
#	lib/collections/schemas/analytics.js
#	lib/collections/schemas/groups.js
#	lib/collections/schemas/inventory.js
#	lib/collections/schemas/products.js
#	lib/collections/schemas/revisions.js
#	lib/collections/schemas/tags.js

@spencern spencern merged commit 76c9d51 into release-1.7.0 Jan 26, 2018

4 checks passed

Codacy/PR Quality Review Good work! A positive pull request.
Details
WIP ready for review
Details
ci/circleci Your tests passed on CircleCI!
Details
security/snyk No new issues
Details

@spencern spencern deleted the style-3568-part3-spencern-eslint-update-3 branch Jan 26, 2018

@spencern spencern referenced this pull request Jan 27, 2018

Merged

Release 1.7.0 #3605

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.