Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix): restore remove from cart functionality #3657

Merged
merged 1 commit into from Feb 13, 2018

Conversation

2 participants
@spencern
Copy link
Member

spencern commented Feb 7, 2018

Resolves #3669

Impact: critical

Issue

Unable to remove items from cart in release-1.8.0

In #3582 changes were made to the IconButton used to remove items from the cart. This change replaced an <i> which had an id attribute with a React component which did not include the id attribute. The handleRemoveItem method was not updated and relied on the id.

5056c6b

Solution

  1. Add an intermediate removalClick class function to the CartItems component
  2. Call this.props.handleRemoveItem from that function with the current item
  3. Update the handleRemoveItem event handler to remove the item passed in and fade out the closest cart item to the target.

Testing

  1. Make sure you can remove items from the cart
(fix): restore remove from cart functionality
Remove from cart functionality was broken in the a11y eslint PR, this fixes it.

@spencern spencern requested a review from mikemurray Feb 7, 2018

@spencern spencern merged commit b7b2235 into release-1.8.0 Feb 13, 2018

4 checks passed

Codacy/PR Quality Review Good work! A positive pull request.
Details
WIP ready for review
Details
ci/circleci Your tests passed on CircleCI!
Details
security/snyk No dependency changes
Details

@spencern spencern deleted the fix-restore-remove-from-cart-functionality branch Feb 13, 2018

This was referenced Feb 15, 2018

@spencern spencern referenced this pull request Mar 9, 2018

Merged

Release 1.9.0 #3941

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.