Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #3766: Checking for shipping address and billing address #3771

Merged
merged 1 commit into from Feb 21, 2018

Conversation

3 participants
@Akarshit
Copy link
Contributor

commented Feb 16, 2018

Resolves #3766
Impact: minor
Type: bugfix

Issue

Only the billing and shipping object were being checked for existence. It was not checked if they actually had and address or not.

Solution

Now checking if those object contain the address field.

Testing

  1. Visit the site in incognito mode
  2. Add something to cart
  3. Click on "Continue as Guest"
  4. Enter the email
  5. Observe no shipping methods are displayed
  6. Once you enter your address the shipping methods display as expected.

@aaronjudd aaronjudd merged commit f8fa813 into release-1.8.0 Feb 21, 2018

4 checks passed

Codacy/PR Quality Review Good work! A positive pull request.
Details
WIP ready for review
Details
ci/circleci Your tests passed on CircleCI!
Details
security/snyk No new issues
Details

@zenweasel zenweasel deleted the fix-3766-akarshit-shipping-workflow branch Feb 21, 2018

@spencern spencern referenced this pull request Feb 22, 2018

Merged

Release 1.8.0 #3645

@spencern spencern referenced this pull request Mar 9, 2018

Merged

Release 1.9.0 #3941

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.