Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #2286: added currency formatting #3808

Merged
merged 1 commit into from Feb 22, 2018

Conversation

2 participants
@Akarshit
Copy link
Contributor

commented Feb 21, 2018

Resolves #2286, #2892
Impact: minor
Type: bugfix

Issue

The problem was formatting was only applied to the placeholder

Solution

Currency formatting is now applied to the value

Testing

  1. Create a product
  2. For a variant enter a price and an MSRP
  3. Observe the price and MSRP are formatted as currency once out of focus.
  4. Try to edit the value and then make them out of focus
  5. Observe the price is again formatted as currency.

@Akarshit Akarshit requested a review from jshimko Feb 21, 2018

@spencern
Copy link
Member

left a comment

@Akarshit @zenweasel approving this, I think there is one more field that should be a currency field in the fulfillment "refund" step. We should use this same currency component there as well, though that can be a separate PR.

@spencern spencern merged commit a993702 into release-1.8.0 Feb 22, 2018

4 checks passed

Codacy/PR Quality Review Good work! A positive pull request.
Details
WIP ready for review
Details
ci/circleci Your tests passed on CircleCI!
Details
security/snyk No new issues
Details

@spencern spencern deleted the fix-2286-akarshit-currency branch Feb 22, 2018

This was referenced Feb 22, 2018

@spencern spencern referenced this pull request Mar 9, 2018

Merged

Release 1.9.0 #3941

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.