Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Fix 3811) Fix can't change localization values #3817

Merged
merged 1 commit into from Feb 22, 2018

Conversation

2 participants
@zenweasel
Copy link
Member

commented Feb 22, 2018

Resolves #3811
Impact: critical
Type: bugfix

Issue

Some improvement to the form control added a fieldProps property which allows you to override some behaviors. The current version expects this to always be there, but existing dashboard panels that use this library were not passing this in because it didn't exist before

Solution

Add an empty object to the defaultProps

Breaking changes

None

Testing

  1. Go to localization settings in the dashboard
  2. Observe that you can now change these settings

@zenweasel zenweasel requested a review from spencern Feb 22, 2018

@spencern
Copy link
Member

left a comment

Resolves critical issue preventing a shop from setting defaults. Leaves a lot of setState issues in it's wake, but that's not the fault of this PR and we've got a separate issue to resolve that as well.

@spencern spencern merged commit 2ecc8d8 into release-1.8.0 Feb 22, 2018

4 checks passed

Codacy/PR Quality Review Good work! A positive pull request.
Details
WIP ready for review
Details
ci/circleci Your tests passed on CircleCI!
Details
security/snyk No new issues
Details

@spencern spencern deleted the fix-3811-brent-form-control-missing-props branch Feb 22, 2018

@spencern spencern referenced this pull request Feb 22, 2018

Merged

Release 1.8.0 #3645

@spencern spencern referenced this pull request Mar 9, 2018

Merged

Release 1.9.0 #3941

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.