Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added all the missing avalara settings fields to the fieldsProps… #3969

Merged
merged 1 commit into from Mar 10, 2018

Conversation

2 participants
@nnnnat
Copy link
Member

nnnnat commented Mar 10, 2018

Resolves #3967
Impact: critical
Type: bugfix

Issue

The Avalara taxes plugin settings weren't rendering all of the needed input fields. I believe this issue was being caused by the simple schema changes and the Form component not knowing to render most of the fields as it looped through the props.

Solution

Inside the AvalaraSettingsFormContainer container, I updated the formSettings object to include a renderComponent & inputType for each needed field. Now the Form component can use the renderComponent property of each field to determine which field to render.

Testing

  1. Remove settings.json
  2. Start the app
  3. Login as admin
  4. Open Avalara panel. All needed form fields should render.
fix: added all the missing avalara settings fields to the fieldsProps…
… so they willl be render by the form component

@nnnnat nnnnat requested a review from spencern Mar 10, 2018

@spencern
Copy link
Member

spencern left a comment

Looks good.

@aldeed This may not be necessary once we transition away from autoform, but I'm going to approve as a fix for now.

@spencern spencern merged commit d411560 into release-1.9.0 Mar 10, 2018

3 checks passed

WIP ready for review
Details
ci/circleci Your tests passed on CircleCI!
Details
security/snyk No new issues
Details

@spencern spencern deleted the fix-3967-nnnnat-avalara-settings-form branch Mar 10, 2018

@zenweasel zenweasel referenced this pull request Mar 11, 2018

Closed

Avalara settings panel doesn't have api key field #3967

3 of 3 tasks complete

@spencern spencern referenced this pull request Mar 14, 2018

Merged

Release 1.9.0 #3941

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.