Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct some translation errors for i18n/it.json #4174

Merged
merged 1 commit into from Apr 19, 2018

Conversation

3 participants
@alyoshz
Copy link
Contributor

commented Apr 12, 2018

There are still many errors

Impact: minor

Issue

The Italian translation is full of errors, probably due to an online translator.

Correct some translation errors for i18n/it.json
There are still many errors
@alyoshz

This comment has been minimized.

Copy link
Owner Author

commented on private/data/i18n/it.json in 4a6778d Apr 12, 2018

Cruscotto is the literal italian translation of Dashboard used for cars, not used in italy in IT. instead it is preferred Dashboard from english or Pannello di controllo (control panel, intrument panel).

@alyoshz

This comment has been minimized.

Copy link
Owner Author

commented on private/data/i18n/it.json in 4a6778d Apr 12, 2018

Automobile = Car

@alyoshz

This comment has been minimized.

Copy link
Owner Author

commented on private/data/i18n/it.json in 4a6778d Apr 12, 2018

See line 35

@zenweasel zenweasel self-requested a review Apr 13, 2018

@zenweasel
Copy link
Member

left a comment

I will have to take your word for it on the translations but thanks!

@zenweasel zenweasel changed the base branch from master to release-1.11.0 Apr 13, 2018

@spencern spencern merged commit e5508df into reactioncommerce:release-1.11.0 Apr 19, 2018

9 checks passed

WIP ready for review
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: docker-build Your tests passed on CircleCI!
Details
ci/circleci: docker-push Your tests passed on CircleCI!
Details
ci/circleci: dockerfile-lint Your tests passed on CircleCI!
Details
ci/circleci: eslint Your tests passed on CircleCI!
Details
ci/circleci: test-app Your tests passed on CircleCI!
Details
ci/circleci: test-unit Your tests passed on CircleCI!
Details
security/snyk No dependency changes
Details

@spencern spencern referenced this pull request Apr 19, 2018

Merged

Release 1.11.0 #4151

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.