Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

devserver improvements #4220

Merged
merged 2 commits into from Apr 27, 2018

Conversation

2 participants
@aldeed
Copy link
Member

commented Apr 27, 2018

Impact: minor
Type: chore

Changes

  • The devserver, when running, now watches only /imports and /.reaction, and watches the .graphql files (i.e., will restart if you edit a graphql schema only)
  • The devserver now hosts the /public folder statically.

Breaking changes

None

Testing

With devserver running:

  1. Make sure it restarts when you edit a GraphQL schema file.
  2. Make sure it does not restart when you edit a file somewhere in, for example, /lib.
  3. Make sure you can access http://localhost:3030/resources/placeholder.gif (or any other static file in /public)

@aldeed aldeed self-assigned this Apr 27, 2018

@aldeed aldeed added this to the Conundrum milestone Apr 27, 2018

@aldeed aldeed requested a review from mikemurray Apr 27, 2018

@mikemurray
Copy link
Member

left a comment

LGTM

@mikemurray mikemurray merged commit bce77c4 into release-1.12.0 Apr 27, 2018

9 of 10 checks passed

ci/circleci: snyk-security Your tests failed on CircleCI
Details
WIP ready for review
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: docker-build Your tests passed on CircleCI!
Details
ci/circleci: docker-push Your tests passed on CircleCI!
Details
ci/circleci: dockerfile-lint Your tests passed on CircleCI!
Details
ci/circleci: eslint Your tests passed on CircleCI!
Details
ci/circleci: test-app Your tests passed on CircleCI!
Details
ci/circleci: test-unit Your tests passed on CircleCI!
Details
security/snyk No new issues
Details

@mikemurray mikemurray deleted the chore-aldeed-devserver-improvements branch Apr 27, 2018

@spencern spencern referenced this pull request May 31, 2018

Merged

Release 1.12.0 #4287

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.