Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new Reaction component library components for the SMS settings form #4318

Merged
merged 5 commits into from Jun 21, 2018

Conversation

2 participants
@aldeed
Copy link
Member

commented Jun 12, 2018

Impact: minor
Type: feature

Changes

To start working toward better UI consistency, a simple form pattern, and removal of remaining autoforms, we're planning to use ReactoForm package with our own form input components for our new operator UI. This PR pulls in those NPM packages and tries out the approach with a single form, the SMS Settings form.

Breaking changes

None

Testing

  1. Start the app and log in as admin
  2. Open SMS admin dashboard
  3. Play around with the form entering various valid and invalid values. Make sure you see proper errors for invalid values. Make sure valid values are saved.
  4. When going to a different admin panel and then back, make sure current saved values are shown in the form. When refreshing the page, make sure current saved values are shown in the form.

@aldeed aldeed self-assigned this Jun 12, 2018

@aldeed aldeed added this to the Grays milestone Jun 12, 2018

@aldeed aldeed changed the title Use new Reaction component library components for the SMS settings form [WIP] Use new Reaction component library components for the SMS settings form Jun 12, 2018

@aldeed aldeed changed the title [WIP] Use new Reaction component library components for the SMS settings form Use new Reaction component library components for the SMS settings form Jun 12, 2018

@aldeed aldeed requested a review from nnnnat Jun 12, 2018

@aldeed

This comment has been minimized.

Copy link
Member Author

commented Jun 15, 2018

@nnnnat Input icons should be fixed now. For now, I'm passing them in directly. Later we can replace this with the idea of pulling components from React context.

@nnnnat

nnnnat approved these changes Jun 21, 2018

@nnnnat nnnnat merged commit 7e7acbc into release-1.14.0 Jun 21, 2018

10 checks passed

WIP ready for review
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: docker-build Your tests passed on CircleCI!
Details
ci/circleci: docker-push Your tests passed on CircleCI!
Details
ci/circleci: dockerfile-lint Your tests passed on CircleCI!
Details
ci/circleci: eslint Your tests passed on CircleCI!
Details
ci/circleci: snyk-security Your tests passed on CircleCI!
Details
ci/circleci: test-app Your tests passed on CircleCI!
Details
ci/circleci: test-unit Your tests passed on CircleCI!
Details
security/snyk - package.json No new issues
Details

@nnnnat nnnnat deleted the feat-aldeed-comp-lib-sms branch Jun 21, 2018

@spencern spencern referenced this pull request Jun 25, 2018

Merged

Release 1.14.0 #4338

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.