Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Move all /server files to plugins #4366
Move all files from within /server to various plugins
For any custom code or community plugins, all imports with paths that begin with
General smoke testing to catch any refactor errors. No substantial code or logic changes were made.
spencern left a comment •
Seeing issues with checkout, orders are not getting created.
Using the example payment method and flat rate shipping, add a product to your cart and step through guest checkout.
I'm seeing issues when adding an address, there's a delay before the address shows up and the create address form is shown again.
Upon placing an order, the user is taken to the
After attempting to place an order using Stripe, the charge was authorized, but the order was never created.
@spencern I fixed the order completion issue. One of the method hooks wasn't firing, maybe because of timing of when it was added, but it made more sense to just move that code into the method it was hooking. I verified that the other method hooks are running.
I see the address slowness thing, too, but I don't see how my changes would have impacted that. It does work eventually, but it's slow. I feel like we debugged and fixed that issue awhile back. Not sure it is worth our time.
I also noticed errors because Twilio and Nexmo were not being imported correctly, and adjusted those imports. You may want to retest sms sending.