Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(refactor) Remove TaxCloud plugin #4428

Merged
merged 1 commit into from Jul 17, 2018

Conversation

Projects
None yet
3 participants
@Akarshit
Copy link
Contributor

commented Jul 13, 2018

Partially resolves: #4308
Impact: breaking
Type: refactor

Issue

This plugin is included by default even though the vast majority of people will not be using it

Solution

Move this plugin to the "community" namespace.

Breaking changes

To continue to use this plugin after this change you will need to:

  1. Clone this repo into <reaction root>/imports/plugins/custom/
  2. No additional changes should be required

Testing

App works w/o plugin

  1. rm -rf node_modules
  2. meteor npm install
  3. Start app
  4. Ensure everything works as normal

Community app works

  1. reaction reset -y
  2. Start app and ensure TaxCloud is not available
  3. Follow instructions in the README for installing
  4. Ensure TaxCloud plugin works as before

@Akarshit Akarshit changed the title (refactor) Remove Avalara plugin (refactor) Remove TaxCloud plugin Jul 13, 2018

@Akarshit Akarshit force-pushed the fix-4308-move-taxcloud branch to c125b60 Jul 13, 2018

@Akarshit Akarshit requested a review from zenweasel Jul 15, 2018

@zenweasel
Copy link
Member

left a comment

Tested. Verified works well

@spencern spencern merged commit de3e938 into release-1.14.0 Jul 17, 2018

10 of 11 checks passed

License Compliance 6 issues found
Details
WIP ready for review
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: docker-build Your tests passed on CircleCI!
Details
ci/circleci: docker-push Your tests passed on CircleCI!
Details
ci/circleci: dockerfile-lint Your tests passed on CircleCI!
Details
ci/circleci: eslint Your tests passed on CircleCI!
Details
ci/circleci: snyk-security Your tests passed on CircleCI!
Details
ci/circleci: test-app Your tests passed on CircleCI!
Details
ci/circleci: test-unit Your tests passed on CircleCI!
Details
security/snyk - package.json No dependency changes
Details

@spencern spencern deleted the fix-4308-move-taxcloud branch Jul 17, 2018

@spencern spencern referenced this pull request Jul 19, 2018

Merged

Release 1.14.0 #4338

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.