Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added migration for adding available payment methods to shops. #4729

Merged
merged 7 commits into from Oct 22, 2018

Conversation

2 participants
@rosshadden
Copy link
Member

rosshadden commented Oct 12, 2018

Resolves #4717
Impact: minor
Type: feature

Description

Need to add payment methods migration for the new Shop@availablePaymentMethods property.

Breaking changes

None.

Testing

Run the migration, and optionally the reverse migration for full cycle test.

@rosshadden rosshadden self-assigned this Oct 12, 2018

@rosshadden rosshadden requested a review from aldeed Oct 12, 2018

@aldeed
Copy link
Member

aldeed left a comment

Needs a few changes

@aldeed

This comment has been minimized.

Copy link
Member

aldeed commented Oct 15, 2018

These are the manual testing requirements for this:

GIVEN I have no payment methods enabled on the Payment tab and Marketplace is disabled
WHEN The migration has finished
THEN shop.availablePaymentMethods should be an empty array

GIVEN I have no payment methods enabled on the Payment tab and Marketplace is enabled
WHEN The migration has finished
THEN shop.availablePaymentMethods should have only "marketplace_stripe_card"

GIVEN I have all payment methods enabled on the Payment tab and Marketplace is disabled
WHEN The migration has finished
THEN shop.availablePaymentMethods should have "iou_example" and "stripe_card"

GIVEN I have all payment methods enabled on the Payment tab and Marketplace is enabled
WHEN The migration has finished
THEN shop.availablePaymentMethods should have "iou_example" and "marketplace_stripe_card"

@aldeed

aldeed approved these changes Oct 16, 2018

@aldeed

This comment has been minimized.

Copy link
Member

aldeed commented Oct 16, 2018

Moved this to Ready, but not merging yet because there will be less possibility of confusion if we merge this at the same time as the related Meteor UI changes.

@aldeed

This comment has been minimized.

Copy link
Member

aldeed commented Oct 16, 2018

@rosshadden Actually I merged another PR with migration 41 in it, so can you rebase and bump this one to 42 (in filename, import, and the integer in the code)?

@spencern spencern changed the base branch from release-2.0.0-rc.5 to release-2.0.0-rc.6 Oct 18, 2018

@aldeed aldeed merged commit b435f41 into release-2.0.0-rc.6 Oct 22, 2018

12 checks passed

License Compliance All checks passed.
Details
WIP ready for review
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: deploy-to-ecs Your tests passed on CircleCI!
Details
ci/circleci: docker-build Your tests passed on CircleCI!
Details
ci/circleci: docker-push Your tests passed on CircleCI!
Details
ci/circleci: dockerfile-lint Your tests passed on CircleCI!
Details
ci/circleci: eslint Your tests passed on CircleCI!
Details
ci/circleci: snyk-security Your tests passed on CircleCI!
Details
ci/circleci: test-app Your tests passed on CircleCI!
Details
ci/circleci: test-unit Your tests passed on CircleCI!
Details
security/snyk - package.json (Reaction Commerce) No new issues
Details

@aldeed aldeed deleted the feat-4717-payment-methods-migration branch Oct 22, 2018

@spencern spencern referenced this pull request Nov 6, 2018

Merged

Release 2.0.0 rc.6 #4755

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.