Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 4769 nnnnat edit groups panel #4771

Merged
merged 1 commit into from Oct 23, 2018

Conversation

3 participants
@nnnnat
Copy link
Member

commented Oct 22, 2018

Resolves #4769
Impact: minor
Type: bugfix

Issue

see #4769

Solution

if nextProps.selectedGroup is undefined use props.selectedGroup in EditGroups component

Breaking changes

N/A

Testing

  1. Log-in as Admin account
  2. Click Accounts
  3. Edit an existing group's properties, see no console error and the setting updates.

@nnnnat nnnnat self-assigned this Oct 22, 2018

@nnnnat nnnnat requested a review from jeffcorpuz Oct 22, 2018

@jeffcorpuz
Copy link
Contributor

left a comment

Works!

@spencern spencern merged commit bad3642 into release-1.17.0 Oct 23, 2018

10 of 11 checks passed

ci/circleci: test-app Your tests failed on CircleCI
Details
License Compliance All checks passed.
Details
WIP ready for review
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: docker-build Your tests passed on CircleCI!
Details
ci/circleci: docker-push Your tests passed on CircleCI!
Details
ci/circleci: dockerfile-lint Your tests passed on CircleCI!
Details
ci/circleci: eslint Your tests passed on CircleCI!
Details
ci/circleci: snyk-security Your tests passed on CircleCI!
Details
ci/circleci: test-unit Your tests passed on CircleCI!
Details
security/snyk - package.json (Reaction Commerce) No new issues
Details

@spencern spencern deleted the fix-4769-nnnnat-edit-groups-panel branch Oct 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.