Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update detailView when its data changes #4791

Merged
merged 1 commit into from Nov 1, 2018

Conversation

2 participants
@spencern
Copy link
Member

commented Nov 1, 2018

Resolves #4777
Impact: major
Type: bugfix

Issue

Selected order does not update order detail view.
If you select orders in the order list screen the order details screen doesn't change to reflect that
http://g.recordit.co/mQXkXwNZcM.gif

Solution

Port solution from #4659 directly.

Properly handle detail view state in ActionView component.

Create function to get derived state from props and remove this.setState method calls from componentDidUpdate lifecycle methods.

Breaking changes

n/a

Testing

  1. Create some orders
  2. Select the first order and observe the proper details are shown
  3. Select another order and ensure that the proper details are still shown.

@spencern spencern merged commit 170291c into release-1.17.0 Nov 1, 2018

4 checks passed

License Compliance All checks passed.
Details
WIP ready for review
Details
build_and_test Workflow: build_and_test
Details
security/snyk - package.json (Reaction Commerce) No new issues
Details

@spencern spencern deleted the fix-4777-order-detail-not-in-sync branch Nov 1, 2018

@spencern spencern referenced this pull request Nov 15, 2018

Merged

Release 1.17.0 #4761

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.