Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: email settings update on cancel #4792

Merged
merged 2 commits into from Nov 1, 2018

Conversation

1 participant
@spencern
Copy link
Member

commented Nov 1, 2018

Resolves #4773
Impact: minor
Type: bugfix

Issue

In the Email settings configuration panel on the admin sidebar, attempting to cancel a change to the email provider settings when the email provider settings are not verifiable is impossible and the changes will be saved regardless of clicking "Save" or "Cancel"

Solution

Resolves #4773 E-mail settings update despite "Cancel" on verification prompt
Issue was that settings were being saved for both confirm and cancel choices.
Fixes the "email settings could not be verified" alert to save only on "confirm"

Breaking changes

n/a

Testing

  1. As an admin, open the email settings configuration panel
  2. Change the settings to something invalid such as
  service: custom
  host: 123
  port: 123
  user: 12345
  password: 00000

and click "save" when presented with an option.
3. Change at least one of the settings again, and click "cancel"
4. Verify that the changes were not saved when you clicked cancel.

Note: the form will not be reset to the original values, but the unsaved values will not be persisted to the database

spencern added some commits Nov 1, 2018

fix: email configuration settings update on cancel
Resolves #4773 E-mail settings update despite "Cancel" on verification prompt
Issue was that settings were being saved for both confirm and cancel choices.
Fix the "email settings could not be verified" alert to save only on "confirm"

@spencern spencern merged commit f26f007 into release-1.17.0 Nov 1, 2018

3 checks passed

License Compliance All checks passed.
Details
WIP ready for review
Details
security/snyk - package.json (Reaction Commerce) No new issues
Details

@spencern spencern deleted the fix-4773-email-settings-update-on-cancel branch Nov 1, 2018

@spencern spencern referenced this pull request Nov 15, 2018

Merged

Release 1.17.0 #4761

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.