Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: custom tax rates not applied #4806

Merged
merged 3 commits into from Nov 15, 2018

Conversation

2 participants
@spencern
Copy link
Member

spencern commented Nov 14, 2018

Resolves #4775
Impact: critical
Type: bugfix

Issue

Custom tax rates were not being applied.

Solution

Issue was primarily that within the addCartItems method, there was a line using chosenVariant.taxable instead of isTaxable. As the property taxable was changed to isTaxable in a previous version, this caused custom tax rates not to work.

This solution caused some other issues to show that were resolved by adding subtotal and tax to the CartItem schema.

Breaking changes

none

Testing

  1. As an operator create a custom tax rate (I've been using NY with postal 11011), setup flat rate shipping, and example payment.
  2. As a customer add an example product to cart, proceed to checkout, and use an address that matches your custom tax rate.
  3. Confirm that the tax rate is applied to the cart and order.

@spencern spencern requested a review from aldeed Nov 14, 2018

@aldeed

aldeed approved these changes Nov 15, 2018

@aldeed aldeed merged commit 95df3ad into release-1.17.0 Nov 15, 2018

3 checks passed

License Compliance Analysis timed out. Check FOSSA for updates.
Details
WIP ready for review
Details
security/snyk - package.json (Reaction Commerce) No new issues
Details

@aldeed aldeed deleted the fix-4664-custom-tax-rates branch Nov 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.