Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(refactor): add isBackorder data to variants #4855

Merged

Conversation

3 participants
@kieckhafer
Copy link
Member

commented Dec 5, 2018

Resolves #4814
Impact: minor
Type: refactor

Issue

The isBackorder property is only added to a top-level Catalog item and not added to the item's variants or options.

Solution

  • Add isBackorder field to the schemas for Catalog and Product
  • Add isBackorder to Graphql endpoint for Catalog
  • Add isBackorder computation in createCatalogProduct xform

Breaking changes

None

Testing

  1. Publish a product to the catalog.
  2. See that isBackorder field is present in Mongo
  3. See that isBackorder field is present in Catalog Graphql endpoint

@kieckhafer kieckhafer requested a review from nnnnat Dec 5, 2018

@kieckhafer kieckhafer changed the base branch from master to release-2.0.0-rc.8 Dec 5, 2018

@kieckhafer kieckhafer changed the title (refactor): Refactor 4814 kieckhafer add is backorder to variants (refactor): add isBackorder data to variants Dec 5, 2018

@kieckhafer kieckhafer requested a review from aldeed Dec 6, 2018

kieckhafer added some commits Dec 6, 2018

@aldeed

aldeed approved these changes Dec 6, 2018

@aldeed aldeed merged commit 87140eb into release-2.0.0-rc.8 Dec 6, 2018

3 checks passed

License Compliance All checks passed.
Details
WIP ready for review
Details
security/snyk - package.json (Reaction Commerce) No new issues
Details

@aldeed aldeed deleted the refactor-4814-kieckhafer-addIsBackorderToVariants branch Dec 6, 2018

@nnnnat
Copy link
Member

left a comment

haha this got merged while I was reviewing but it looks great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.