Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add updateOrderFulfillmentGroup mutation #5020

Merged
merged 6 commits into from Mar 7, 2019

Conversation

@aldeed
Copy link
Member

aldeed commented Mar 6, 2019

Part of #4999
Impact: minor
Type: feature

Changes

A new updateOrderFulfillmentGroup mutation allows you to change the tracking and status fields of an order fulfillment group after the order has been placed.

The operator UI now uses this mutation for the tracking update only. Changing the operator UI to use GraphQL for group status updates will be done in a later PR.

  • updateOrderFulfillmentGroup can be called internally to synchronize from an external system by setting context.isInternalCall to true
  • updateOrderFulfillmentGroup can be called through GraphQL by any user with "orders" permission for the shop that owns the order
  • The "orders/updateShipmentTracking" Meteor method is removed in favor of the updateOrderFulfillmentGroup GraphQL mutation

Breaking changes

None

Testing

  1. Place an order.
  2. Verify that the mutation works as described.
  3. Verify that you can update the order fulfillment group status and tracking when authenticated as a user with "orders" role, but not when authenticated as someone else or when not authenticated.
  4. Verify that saving the Tracking field in the operator UI works.

aldeed added some commits Mar 6, 2019

feat: add updateOrderFulfillmentGroup internal mutation
Signed-off-by: Eric Dobbertin <eric@dairystatedesigns.com>
feat: add updateOrderFulfillmentGroup GraphQL mutation
Signed-off-by: Eric Dobbertin <eric@dairystatedesigns.com>
feat: remove "orders/updateShipmentTracking" Meteor method
Signed-off-by: Eric Dobbertin <eric@dairystatedesigns.com>

@aldeed aldeed self-assigned this Mar 6, 2019

@aldeed aldeed requested a review from kieckhafer Mar 6, 2019

@aldeed aldeed added this to the 🏔 Uncompahgre milestone Mar 6, 2019

aldeed added some commits Mar 7, 2019

feat: support setting trackingUrl on order fulfillment group
Signed-off-by: Eric Dobbertin <eric@dairystatedesigns.com>
@aldeed

This comment has been minimized.

Copy link
Member Author

aldeed commented Mar 7, 2019

@kieckhafer I add trackingUrl in 1c86ee9 per discussion in the other PR

@kieckhafer
Copy link
Member

kieckhafer left a comment

Looks good, one quick question but good to approve.

orderId,
orderFulfillmentGroupId,
status,
tracking

This comment has been minimized.

Copy link
@kieckhafer

kieckhafer Mar 7, 2019

Member

See that you noted trackingUrl is not updated here yet. Should we go ahead and add it already to keep this in sync with what the other mutation can do?

This comment has been minimized.

Copy link
@aldeed

aldeed Mar 7, 2019

Author Member

I'd rather wait until we actually add a field in UI for it and need it here.

comment update
Signed-off-by: Erik Kieckhafer <ek@ato.la>

@kieckhafer kieckhafer merged commit 4e19818 into develop Mar 7, 2019

3 checks passed

License Compliance All checks passed.
Details
WIP ready for review
Details
security/snyk - package.json (Reaction Commerce) No manifest changes detected

@kieckhafer kieckhafer deleted the feat-aldeed-update-order-group branch Mar 7, 2019

@jeffcorpuz jeffcorpuz referenced this pull request Mar 19, 2019

Merged

Release v2.0.0-rc.11 #5049

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.